Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose remote resolvers type defs #1197

Closed
wants to merge 8 commits into from

Conversation

jasmo2
Copy link

@jasmo2 jasmo2 commented Sep 5, 2019

The following PR is created for the intention of exposing remote Schema resolvers and typeDefs, by doing it we are able to federate the remote-schema , even though these schema does implement apollo-federation

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

@apollo-cla
Copy link

@jasmo2: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@yaacovCR yaacovCR mentioned this pull request Nov 4, 2019
5 tasks
@tombartlettmh
Copy link

Is this PR likely to be merged? If so, could we do it soon 😝

@yaacovCR
Copy link
Collaborator

Merged equivalent in graphql-tools-fork

@etha7
Copy link

etha7 commented Mar 24, 2020

Merged equivalent in graphql-tools-fork

I believe @yaacovCR is referring to this:
graphql-transform-federation

@yaacovCR
Copy link
Collaborator

yaacovCR commented Apr 1, 2020

Closed in favor of #1307

@yaacovCR yaacovCR closed this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants