Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(merge): add default value for mergeDirectives #1671

Merged
merged 1 commit into from Jun 23, 2020
Merged

fix(merge): add default value for mergeDirectives #1671

merged 1 commit into from Jun 23, 2020

Commits on Jun 23, 2020

  1. fix(merge): add default value for mergeDirectives 

    The GraphQL reference implementation treats directives  as optional,
so mergeDirectives needs to handle the `undefined` case, since some
libraries will set `directives` to be undefined instead of an empty list.

see https://github.com/graphql/graphql-js/blob/20a8f555e7eaa5c2fa2fd188abcef83ee8169e7f/src/language/ast.d.ts#L453
    @rufman
    rufman committed Jun 23, 2020
    Copy the full SHA
    693c841 View commit details
    Browse the repository at this point in the history