Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix public signatures for strict option #1783

Merged
merged 2 commits into from
Jul 16, 2020
Merged

fix public signatures for strict option #1783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72636cd
fix public signatures for strict option
yaacovCR Jul 15, 2020
573aee3
fix WrapType for strict
yaacovCR Jul 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/utils/src/Interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,21 +179,21 @@ export interface IFieldResolverOptions<TSource = any, TContext = any, TArgs = an
}

export type SchemaTransform = (originalSchema: GraphQLSchema) => GraphQLSchema;
export type RequestTransform = (
export type RequestTransform<T = Record<string, any>> = (
originalRequest: Request,
delegationContext?: Record<string, any>,
transformationContext?: Record<string, any>
transformationContext?: T
) => Request;
export type ResultTransform = (
export type ResultTransform<T = Record<string, any>> = (
originalResult: ExecutionResult,
delegationContext?: Record<string, any>,
transformationContext?: Record<string, any>
transformationContext?: T
) => ExecutionResult;

export interface Transform {
export interface Transform<T = Record<string, any>> {
transformSchema?: SchemaTransform;
transformRequest?: RequestTransform;
transformResult?: ResultTransform;
transformRequest?: RequestTransform<T>;
transformResult?: ResultTransform<T>;
}

export type FieldNodeMapper = (
Expand Down
10 changes: 5 additions & 5 deletions packages/wrap/src/transforms/WrapFields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function defaultWrappingResolver(
return defaultMergedResolver(parent, args, context, info);
}

export default class WrapFields implements Transform {
export default class WrapFields implements Transform<WrapFieldsTransformationContext> {
private readonly outerTypeName: string;
private readonly wrappingFieldNames: Array<string>;
private readonly wrappingTypeNames: Array<string>;
Expand Down Expand Up @@ -138,8 +138,8 @@ export default class WrapFields implements Transform {

public transformRequest(
originalRequest: Request,
delegationContext: Record<string, any>,
transformationContext: WrapFieldsTransformationContext
delegationContext?: Record<string, any>,
transformationContext?: WrapFieldsTransformationContext
): Request {
transformationContext.nextIndex = 0;
transformationContext.paths = Object.create(null);
Expand All @@ -148,8 +148,8 @@ export default class WrapFields implements Transform {

public transformResult(
originalResult: ExecutionResult,
delegationContext: Record<string, any>,
transformationContext: WrapFieldsTransformationContext
delegationContext?: Record<string, any>,
transformationContext?: WrapFieldsTransformationContext
): ExecutionResult {
return this.transformer.transformResult(originalResult, delegationContext, transformationContext);
}
Expand Down
8 changes: 4 additions & 4 deletions packages/wrap/src/transforms/WrapType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@ export default class WrapType implements Transform {

public transformRequest(
originalRequest: Request,
delegationContext: Record<string, any>,
transformationContext: Record<string, any>
delegationContext?: Record<string, any>,
transformationContext?: Record<string, any>
): Request {
return this.transformer.transformRequest(originalRequest, delegationContext, transformationContext);
}

public transformResult(
originalResult: ExecutionResult,
delegationContext: Record<string, any>,
transformationContext: Record<string, any>
delegationContext?: Record<string, any>,
transformationContext?: Record<string, any>
): ExecutionResult {
return this.transformer.transformResult(originalResult, delegationContext, transformationContext);
}
Expand Down