Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change use of instanceof Promise to use is-promise library #1837

Merged
merged 7 commits into from
Aug 10, 2020
Merged

fix: change use of instanceof Promise to use is-promise library #1837

merged 7 commits into from
Aug 10, 2020

Commits on Jul 28, 2020

  1. fix: wait for promise resolution before returning

    Chris James committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d32f550 View commit details
    Browse the repository at this point in the history

  2. fix: update tests to reflect async result

    Chris James committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    175dd8d View commit details
    Browse the repository at this point in the history

  3. fix linting

    Chris James committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    28e95d1 View commit details
    Browse the repository at this point in the history

  4. Revert "fix: wait for promise resolution before returning" 

    This reverts commit c59c9c4.
    Chris James committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    322afc7 View commit details
    Browse the repository at this point in the history

  5. fix: replace all instanceof Promise check with is-promise library 

    based on feedback:
#1837 (comment)
#1837 (comment)
    Chris James committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    098592b View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Merge branch 'master' into fix-remote-executor

    @cajames
    cajames committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    f34027e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2020

  1. Merge branch 'master' into fix-remote-executor

    @cajames
    cajames committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    794a66c View commit details
    Browse the repository at this point in the history