Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(website) Type Merging docs #1910

Merged
merged 14 commits into from
Aug 16, 2020
Merged

Conversation

gmac
Copy link
Contributor

@gmac gmac commented Aug 14, 2020

Expands the Schema stitching -> Type merging guide with a large set of narrative examples that walk through merging patterns. The existing tech notes are still included at the bottom under the Custom merge resolvers heading. The new guide captures a large portion of the conversation in #1874.

Sorry for the departure from User -> Chirps here! I needed an example that included two of something to analyze the query performance associated with different merging patterns.

Also has notes on the latest merging features, including field-level selectionSets (see #1888).

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@gmac
Copy link
Contributor Author

gmac commented Aug 14, 2020

Hmm, looks like that canary build is still failing for doc-only PRs.

@ardatan
Copy link
Owner

ardatan commented Aug 16, 2020

Thanks @gmac ! That's awesome! No worries for canary release job.

@ardatan ardatan added the docs Focuses on documentation changes label Aug 16, 2020
@ardatan ardatan merged commit 1b1f4b6 into ardatan:master Aug 16, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 6.0.19-alpha-1b1f4b65.0

Quickly update your package.json by running:

npx match-version @graphql-tools 6.0.19-alpha-1b1f4b65.0

@gmac gmac deleted the gm-type-merging-docs branch August 17, 2020 13:44
@gmac
Copy link
Contributor Author

gmac commented Aug 17, 2020

@ardatan – thank you! Is the [deploy_website] prefix still operational? None of the new stitching docs are reflected on the live site.

@ardatan
Copy link
Owner

ardatan commented Aug 17, 2020

@gmac The script was broken but right now it's fixed :) So your changes are reflected now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants