Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce computed fields #1989

Merged
merged 116 commits into from Sep 13, 2020
Merged

Commits on Sep 6, 2020

  1. setup schema filtering.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    acc0a1e View commit details
    Browse the repository at this point in the history
  2. more tests.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    c682dd2 View commit details
    Browse the repository at this point in the history
  3. isolate interfaces.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    b524c35 View commit details
    Browse the repository at this point in the history
  4. add missing imports.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    c9b113d View commit details
    Browse the repository at this point in the history
  5. fix up build.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    aaa88a5 View commit details
    Browse the repository at this point in the history
  6. update integration test.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    7e22836 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6c00754 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    15642e8 View commit details
    Browse the repository at this point in the history
  9. reorganize tests.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    c520140 View commit details
    Browse the repository at this point in the history
  10. curse you .DS_Store!

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    b04ac6a View commit details
    Browse the repository at this point in the history
  11. add shared endpoint.

    gmac committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    2e61370 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Configuration menu
    Copy the full SHA
    0a46178 View commit details
    Browse the repository at this point in the history
  2. consolidate endpoint logic.

    gmac committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    9807405 View commit details
    Browse the repository at this point in the history
  3. no need for new type

    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    e87d145 View commit details
    Browse the repository at this point in the history
  4. let's describe what we want to do the field, doesn't matter why

    computed => isolate
    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    936f45e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2d528ed View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    62e798b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bc6ebc1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3c3ae30 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b7d1ded View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    dd5fb3e View commit details
    Browse the repository at this point in the history
  11. simplify

    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    6c1f8d6 View commit details
    Browse the repository at this point in the history
  12. shorten

    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    278f204 View commit details
    Browse the repository at this point in the history
  13. refactor

    = pull applyComputationsFromSDL into Subschema class
    
    * Subschema class was initially useful when performing delegation outside of wrapSchema context. The class constructor performs some of the preprocessing logic done by wrapSchema. It can be also used to do preprocessing based on the SDL.
    
    = short splitFieldsFromSubschema further => isolateFields
    
    = run isolateFields automatically when using stitchSchemas.
    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    4351bd5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    dd5d685 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3e1519e View commit details
    Browse the repository at this point in the history
  16. remove unnecessary check

    yaacovCR committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    485a0fe View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Configuration menu
    Copy the full SHA
    e12a15b View commit details
    Browse the repository at this point in the history
  2. allow fields syntax

    yaacovCR committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    7c7a5b9 View commit details
    Browse the repository at this point in the history
  3. updated docs (WIP).

    gmac committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1040566 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d62d837 View commit details
    Browse the repository at this point in the history
  5. delegate to base schema when isolating fields

    also remove remnant of named endpoint code
    yaacovCR committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    acfc153 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2 from ardatan/initial-suggestions

    Initial suggestions
    gmac committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    bd3385c View commit details
    Browse the repository at this point in the history
  7. fix build

    yaacovCR committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    c8ebc9c View commit details
    Browse the repository at this point in the history
  8. Temp disable no-unused-vars

    ardatan committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    05f15bd View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4b833f8 View commit details
    Browse the repository at this point in the history
  10. Temp disable no-unused-vars

    ardatan committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    00d100e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d2e6c42 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8ff7678 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. cleanup docs.

    gmac committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    4ef338e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    gmac committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    f893c25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a35b991 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a467c39 View commit details
    Browse the repository at this point in the history
  5. failing tests

    yaacovCR committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    772be86 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    36493ef View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7741f6f View commit details
    Browse the repository at this point in the history
  8. works when batching is disabled, so this is a bug in batching not wit…

    …h fieldSelectionSet isolation
    
    On the other hand, will ignore the price and weight given by its own query in favor of the Product service, so may give different results when queried directly and when queried via Gateway.
    
    So isolation definitely needs to go behind a flag as opt-in. Name of flag might be `fieldSelectionSetsViaGateway` or something like that to describe the different behavior rather than the internal implementation. Anything sound catchier?
    yaacovCR committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    6405b97 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    be330f6 View commit details
    Browse the repository at this point in the history
  10. fix failing tests

    no need to modify subschemaConfig.schema when isolating schemas, this should all be done by transforms
    yaacovCR committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a5b5382 View commit details
    Browse the repository at this point in the history
  11. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    yaacovCR committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1added0 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Configuration menu
    Copy the full SHA
    e2e86d9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    gmac committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    136b2f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    43eead6 View commit details
    Browse the repository at this point in the history
  4. setup schema filtering.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    23af0ec View commit details
    Browse the repository at this point in the history
  5. more tests.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    5f9ae0d View commit details
    Browse the repository at this point in the history
  6. isolate interfaces.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    64206d7 View commit details
    Browse the repository at this point in the history
  7. add missing imports.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    e8bd1cc View commit details
    Browse the repository at this point in the history
  8. fix up build.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    3aba22e View commit details
    Browse the repository at this point in the history
  9. update integration test.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    fadba11 View commit details
    Browse the repository at this point in the history
  10. this safeguard is no longer necessary.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    6e1e372 View commit details
    Browse the repository at this point in the history
  11. refactor into plugin architecture.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    92f5923 View commit details
    Browse the repository at this point in the history
  12. reorganize tests.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    ca1f8e5 View commit details
    Browse the repository at this point in the history
  13. curse you .DS_Store!

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    d1371dc View commit details
    Browse the repository at this point in the history
  14. add shared endpoint.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a9ca788 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    410a1d6 View commit details
    Browse the repository at this point in the history
  16. consolidate endpoint logic.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    ba66160 View commit details
    Browse the repository at this point in the history
  17. updated docs (WIP).

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    e09e954 View commit details
    Browse the repository at this point in the history
  18. cleanup docs.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    2cd39d0 View commit details
    Browse the repository at this point in the history
  19. no need for new type

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b3c9abd View commit details
    Browse the repository at this point in the history
  20. let's describe what we want to do the field, doesn't matter why

    computed => isolate
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    511d21f View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    2a9863a View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    4bb1020 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    f6bcd69 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f4eb54d View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    4062cd7 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    289f3f5 View commit details
    Browse the repository at this point in the history
  27. simplify

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    8eef2d6 View commit details
    Browse the repository at this point in the history
  28. shorten

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a805198 View commit details
    Browse the repository at this point in the history
  29. refactor

    = pull applyComputationsFromSDL into Subschema class
    
    * Subschema class was initially useful when performing delegation outside of wrapSchema context. The class constructor performs some of the preprocessing logic done by wrapSchema. It can be also used to do preprocessing based on the SDL.
    
    = short splitFieldsFromSubschema further => isolateFields
    
    = run isolateFields automatically when using stitchSchemas.
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    907d861 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    ce973f8 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    7c476b2 View commit details
    Browse the repository at this point in the history
  32. remove unnecessary check

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f346461 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    25172cf View commit details
    Browse the repository at this point in the history
  34. allow fields syntax

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f5d3799 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    5e835c8 View commit details
    Browse the repository at this point in the history
  36. delegate to base schema when isolating fields

    also remove remnant of named endpoint code
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    4e52e44 View commit details
    Browse the repository at this point in the history
  37. fix build

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    dc771a7 View commit details
    Browse the repository at this point in the history
  38. Temp disable no-unused-vars

    ardatan authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    525b86d View commit details
    Browse the repository at this point in the history
  39. [deploy_website] deploy website message.

    gmac authored and yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    f43759e View commit details
    Browse the repository at this point in the history
  40. failing tests

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    7e48ed3 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    1be7ab6 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    4c2c8b4 View commit details
    Browse the repository at this point in the history
  43. works when batching is disabled, so this is a bug in batching not wit…

    …h fieldSelectionSet isolation
    
    On the other hand, will ignore the price and weight given by its own query in favor of the Product service, so may give different results when queried directly and when queried via Gateway.
    
    So isolation definitely needs to go behind a flag as opt-in. Name of flag might be `fieldSelectionSetsViaGateway` or something like that to describe the different behavior rather than the internal implementation. Anything sound catchier?
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a05d651 View commit details
    Browse the repository at this point in the history
  44. fix failing tests

    no need to modify subschemaConfig.schema when isolating schemas, this should all be done by transforms
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0fd3fa8 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    cd1e296 View commit details
    Browse the repository at this point in the history
  46. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    gmac committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    4df3e58 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    e1533fc View commit details
    Browse the repository at this point in the history
  48. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    gmac committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    60539bf View commit details
    Browse the repository at this point in the history
  49. fix batch execution

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    301b116 View commit details
    Browse the repository at this point in the history
  50. useGatewaySchema => federate

    default for federate argument for directive \@requires can be set by each schema
    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    4084393 View commit details
    Browse the repository at this point in the history
  51. fix typo

    yaacovCR committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b889cab View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. docs changes

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    0723719 View commit details
    Browse the repository at this point in the history
  2. fix diff

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    9f21e66 View commit details
    Browse the repository at this point in the history
  3. simplify

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    4fe7cdc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bd1819d View commit details
    Browse the repository at this point in the history
  5. finish changing terms

    finish changing computed => federated and static => non-federated
    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    584f56e View commit details
    Browse the repository at this point in the history
  6. polish

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    ecf4e81 View commit details
    Browse the repository at this point in the history
  7. consolidate tests

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    3017364 View commit details
    Browse the repository at this point in the history
  8. rename test file

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    f84f66f View commit details
    Browse the repository at this point in the history
  9. fix test descriptions

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    80eda4f View commit details
    Browse the repository at this point in the history
  10. remove duplicated tests

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    d6522ad View commit details
    Browse the repository at this point in the history
  11. add note

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    0c104d7 View commit details
    Browse the repository at this point in the history
  12. tweak docs

    yaacovCR committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    0818eb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. cleanup extensions intro.

    gmac committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    b2839d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2020

  1. feedback

    yaacovCR committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    802fc31 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'gm-dynamic-merge-fields' of github.com:gmac/graphql-too…

    …ls into gm-dynamic-merge-fields
    yaacovCR committed Sep 13, 2020
    Configuration menu
    Copy the full SHA
    40e2a9a View commit details
    Browse the repository at this point in the history