enhance(docs) Computed fields docs #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💥 No ChangesetLatest commit: c320580 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
|
Added additional notes about |
|
The latest changes of this PR are available as alpha in npm: Quickly update your package.json by running: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs another pass on computed fields documentation tailored to the final implementation that got merged in #1989. Also adds a few additional general notes:
Computed field narrative now focuses exclusively on the core
@computedbehavior that assumes field dependencies are a hard requirement. The supposition of what could happen if storefronts had a local cache of data is removed for now because it conflates what computed IS doing. This supposition of the local cache scenario would be more appropriate in a dedicated section that explores thefieldsfeature–should that establish itself as a widespread use case.Mentions of "Federated" are switched to "Federation". Now that type merging is decided on the "computed" terminology, "Federation" is once more only a proper noun.
Adds notes about query batching options and passing dataloader options.
Adds notes about migrating from schema extensions to type merging.
@yaacovCR – is this a reasonable compromise with your original narrative?
TODO: