Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript commonjs module resolution with node16,nodenext #4624

Merged
merged 5 commits into from Aug 5, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Aug 5, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: c30871c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/delegate Patch
@graphql-tools/graphql-tag-pluck Patch
graphql-tools Patch
@graphql-tools/import Patch
@graphql-tools/jest-transform Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/load-files Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/url-loader Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/optimize Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/utils Patch
@graphql-tools/webpack-loader Patch
@graphql-tools/webpack-loader-runtime Patch
@graphql-tools/wrap Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ❌ Failed (Inspect) Aug 5, 2022 at 9:50AM (UTC)

@theguild-bot
Copy link
Collaborator

theguild-bot commented Aug 5, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/batch-delegate@8.3.2-alpha-b9e4a92b.0
@graphql-tools/batch-execute@8.5.2-alpha-b9e4a92b.0
@graphql-tools/delegate@8.8.2-alpha-b9e4a92b.0
@graphql-tools/graphql-tag-pluck@7.3.2-alpha-b9e4a92b.0
graphql-tools@8.3.2-alpha-b9e4a92b.0
@graphql-tools/import@6.7.2-alpha-b9e4a92b.0
@graphql-tools/jest-transform@1.2.1-alpha-b9e4a92b.0
@graphql-tools/links@8.3.2-alpha-b9e4a92b.0
@graphql-tools/load@7.7.2-alpha-b9e4a92b.0
@graphql-tools/load-files@6.6.1-alpha-b9e4a92b.0
@graphql-tools/apollo-engine-loader@7.3.7-alpha-b9e4a92b.0
@graphql-tools/code-file-loader@7.3.2-alpha-b9e4a92b.0
@graphql-tools/git-loader@7.2.2-alpha-b9e4a92b.0
@graphql-tools/github-loader@7.3.7-alpha-b9e4a92b.0
@graphql-tools/graphql-file-loader@7.5.1-alpha-b9e4a92b.0
@graphql-tools/json-file-loader@7.4.2-alpha-b9e4a92b.0
@graphql-tools/module-loader@7.2.2-alpha-b9e4a92b.0
@graphql-tools/prisma-loader@7.2.9-alpha-b9e4a92b.0
@graphql-tools/url-loader@7.13.4-alpha-b9e4a92b.0
@graphql-tools/merge@8.3.2-alpha-b9e4a92b.0
@graphql-tools/mock@8.7.2-alpha-b9e4a92b.0
@graphql-tools/node-require@6.4.2-alpha-b9e4a92b.0
@graphql-tools/optimize@1.3.1-alpha-b9e4a92b.0
@graphql-tools/relay-operation-optimizer@6.5.2-alpha-b9e4a92b.0
@graphql-tools/resolvers-composition@6.5.2-alpha-b9e4a92b.0
@graphql-tools/schema@8.5.2-alpha-b9e4a92b.0
@graphql-tools/stitch@8.7.2-alpha-b9e4a92b.0
@graphql-tools/stitching-directives@2.3.2-alpha-b9e4a92b.0
@graphql-tools/utils@8.9.1-alpha-b9e4a92b.0
@graphql-tools/webpack-loader@6.7.1-alpha-b9e4a92b.0
@graphql-tools/webpack-loader-runtime@6.4.1-alpha-b9e4a92b.0
@graphql-tools/wrap@8.5.2-alpha-b9e4a92b.0

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 242       ✗ 0  
     data_received..................: 28 MB   2.8 MB/s
     data_sent......................: 104 kB  10 kB/s
     http_req_blocked...............: avg=4.92µs   min=2.6µs   med=3.2µs   max=200µs    p(90)=4µs     p(95)=4.3µs   
     http_req_connecting............: avg=1.15µs   min=0s      med=0s      max=139.3µs  p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=77.09ms  min=67.31ms med=73.58ms max=147.72ms p(90)=85.02ms p(95)=119.94ms
       { expected_response:true }...: avg=77.09ms  min=67.31ms med=73.58ms max=147.72ms p(90)=85.02ms p(95)=119.94ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 121
     http_req_receiving.............: avg=172.05µs min=139.7µs med=159.7µs max=825.41µs p(90)=182.3µs p(95)=201.1µs 
     http_req_sending...............: avg=81.88µs  min=17.39µs med=27.1µs  max=2.86ms   p(90)=31.7µs  p(95)=62.3µs  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=76.83ms  min=67.14ms med=73.39ms max=146.83ms p(90)=83.81ms p(95)=119.75ms
     http_reqs......................: 121     12.031851/s
     iteration_duration.............: avg=83.08ms  min=72.07ms med=78.96ms max=152.67ms p(90)=93.42ms p(95)=124.78ms
     iterations.....................: 121     12.031851/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@n1ru4l n1ru4l changed the title fix: typescript commonjs resolution fix: typescript commonjs module resolution with node16,nodenext Aug 5, 2022
@n1ru4l n1ru4l merged commit e3167ed into master Aug 5, 2022
@n1ru4l n1ru4l deleted the fix-typescript-commonjs-resolution branch August 5, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants