feat: executor from graphql-js #4778

saihaj · 2022-10-25T01:45:23Z

No description provided.

changeset-bot · 2022-10-25T01:45:25Z

🦋 Changeset detected

Latest commit: 6834a14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@graphql-tools/delegate	Patch
@graphql-tools/utils	Minor
@graphql-tools/executor	Patch
@graphql-tools/batch-delegate	Patch
@graphql-tools/links	Patch
@graphql-tools/stitch	Patch
@graphql-tools/stitching-directives	Patch
@graphql-tools/wrap	Patch
@graphql-tools/url-loader	Patch
@graphql-tools/batch-execute	Patch
@graphql-tools/graphql-tag-pluck	Patch
@graphql-tools/import	Patch
@graphql-tools/load	Patch
@graphql-tools/merge	Patch
@graphql-tools/mock	Patch
@graphql-tools/node-require	Patch
@graphql-tools/relay-operation-optimizer	Patch
@graphql-tools/resolvers-composition	Patch
@graphql-tools/schema	Patch
@graphql-tools/apollo-engine-loader	Patch
@graphql-tools/code-file-loader	Patch
@graphql-tools/git-loader	Patch
@graphql-tools/github-loader	Patch
@graphql-tools/graphql-file-loader	Patch
@graphql-tools/json-file-loader	Patch
@graphql-tools/module-loader	Patch
@graphql-tools/prisma-loader	Patch
federation-benchmark	Patch
graphql-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-10-25T01:47:59Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/batch-delegate`	`8.4.2-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/batch-execute`	`8.5.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/delegate`	`9.0.9-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor`	`0.0.1-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-tag-pluck`	`7.3.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`graphql-tools`	`8.3.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/import`	`6.7.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/links`	`8.3.13-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/load`	`7.8.1-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/apollo-engine-loader`	`7.3.14-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/code-file-loader`	`7.3.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/git-loader`	`7.2.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/github-loader`	`7.3.14-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-file-loader`	`7.5.6-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/json-file-loader`	`7.4.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/module-loader`	`7.2.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/prisma-loader`	`7.2.25-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/url-loader`	`7.16.5-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/merge`	`8.3.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/mock`	`8.7.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/node-require`	`6.4.9-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/relay-operation-optimizer`	`6.5.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/resolvers-composition`	`6.5.7-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/schema`	`9.0.5-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitch`	`8.7.14-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitching-directives`	`2.3.12-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/utils`	`8.13.0-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎
`@graphql-tools/wrap`	`9.2.4-alpha-20221027114856-883e0476`	npm ↗︎ unpkg ↗︎

github-actions · 2022-10-25T01:48:29Z

❌ Benchmark Failed

Performance regression detected: it seems like your Pull Request adds some extra latency to Schema Stitching

If the performance regression is expected, please increase the failing threshold.

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 154      ✗ 0  
     data_received..................: 18 MB   1.8 MB/s
     data_sent......................: 66 kB   6.6 kB/s
     http_req_blocked...............: avg=7.09µs   min=3.2µs    med=3.7µs    max=225.8µs  p(90)=5.04µs   p(95)=5.92µs  
     http_req_connecting............: avg=2µs      min=0s       med=0s       max=154.5µs  p(90)=0s       p(95)=0s      
   ✗ http_req_duration..............: avg=122.73ms min=99.94ms  med=115.51ms max=242.61ms p(90)=146.12ms p(95)=172.81ms
       { expected_response:true }...: avg=122.73ms min=99.94ms  med=115.51ms max=242.61ms p(90)=146.12ms p(95)=172.81ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 77 
     http_req_receiving.............: avg=213.47µs min=158µs    med=184µs    max=1.02ms   p(90)=228.12µs p(95)=410.11µs
     http_req_sending...............: avg=115.71µs min=18.8µs   med=32.6µs   max=3.59ms   p(90)=49.6µs   p(95)=70.38µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=122.4ms  min=99.71ms  med=115.3ms  max=241.51ms p(90)=145.89ms p(95)=172.58ms
     http_reqs......................: 77      7.670963/s
     iteration_duration.............: avg=130.3ms  min=105.64ms med=123.34ms max=249.01ms p(90)=151.96ms p(95)=179.33ms
     iterations.....................: 77      7.670963/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

github-actions · 2022-10-25T01:50:59Z

🚀 Website Preview

The latest changes to the website are available as preview in: https://d3e608f6.graphql-tools.pages.dev

This reverts commit c6a6204.

glasser · 2022-10-28T17:47:14Z

packages/utils/src/Path.ts

@@ -0,0 +1,34 @@
+import { Maybe } from './types';


@ardatan As part of building for ESM you are trying to stick to "all imports have an extension", right? Looks like this line and the MaybePromise import in jsutils.ts are missing the extension, which breaks builds with tsc moduleResolution nodenext.

PR on its way to fix and add lint rule.

Some pure-ESM processors (eg, `tsc` with `moduleResolution: 'nodenext') require extensions on all imports. ardatan#4778 added two import-less extensions. This PR fixes them and adds linting (from an already-installed plugin) to catch future errors. Test execution does not appear to require these extensions so we only check non-test files (there's another 17 errors to fix if you want to check tests too).

Some pure-ESM processors (eg, `tsc` with `moduleResolution: 'nodenext') require extensions on all imports. #4778 added two import-less extensions. This PR fixes them and adds linting (from an already-installed plugin) to catch future errors. Test execution does not appear to require these extensions so we only check non-test files (there's another 17 errors to fix if you want to check tests too).

saihaj mentioned this pull request Oct 25, 2022

feat: use experimental executor from tools dotansimha/graphql-yoga#1948

Closed

saihaj and others added 14 commits October 25, 2022 14:28

feat: executor from graphql-js

a9f3154

Some cleanup

ded25b2

Make it even more agnostic

4877881

Do not fail fast

372b831

Go

5ee28e5

No more jsutils

c073e95

Go

4aa7e5e

More

9f1afb0

Revert "Go"

3684d03

This reverts commit c6a6204.

make it use tools more

8abb541

fix build

6bbd2af

remove fn in fork

a8746a9

changeset

efdc329

bad rebase

4e22f36

saihaj force-pushed the saihaj/executor branch from abe4259 to 4e22f36 Compare October 25, 2022 18:29

ardatan and others added 6 commits October 27, 2022 13:09

Drop v15

ff6c57c

Drop v14

44e2386

Use more from executor

3824758

chore(dependencies): updated changesets for modified dependencies

0bc25c5

Go

2c2856b

Yes

9f704e2

ardatan marked this pull request as ready for review October 27, 2022 11:21

github-actions bot and others added 3 commits October 27, 2022 11:21

chore(dependencies): updated changesets for modified dependencies

d0bca65

Go

a4f095f

Relax

5dbb479

ardatan and others added 2 commits October 27, 2022 14:45

Go

5a481a4

chore(dependencies): updated changesets for modified dependencies

6834a14

ardatan merged commit df5848b into master Oct 27, 2022

ardatan deleted the saihaj/executor branch October 27, 2022 11:59

github-actions bot mentioned this pull request Oct 27, 2022

Upcoming Release Changes #4773

Merged

glasser reviewed Oct 28, 2022

View reviewed changes

glasser mentioned this pull request Oct 28, 2022

Add missing import extension, check with lint #4795

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: executor from graphql-js #4778

feat: executor from graphql-js #4778

saihaj commented Oct 25, 2022 •

edited

changeset-bot bot commented Oct 25, 2022 •

edited

github-actions bot commented Oct 25, 2022 •

edited

github-actions bot commented Oct 25, 2022 •

edited

github-actions bot commented Oct 25, 2022 •

edited

glasser Oct 28, 2022

glasser Oct 28, 2022

glasser Oct 28, 2022

feat: executor from graphql-js #4778

feat: executor from graphql-js #4778

Conversation

saihaj commented Oct 25, 2022 • edited

changeset-bot bot commented Oct 25, 2022 • edited

🦋 Changeset detected

github-actions bot commented Oct 25, 2022 • edited

🚀 Snapshot Release (alpha)

github-actions bot commented Oct 25, 2022 • edited

❌ Benchmark Failed

github-actions bot commented Oct 25, 2022 • edited

🚀 Website Preview

glasser Oct 28, 2022

Choose a reason for hiding this comment

glasser Oct 28, 2022

Choose a reason for hiding this comment

glasser Oct 28, 2022

Choose a reason for hiding this comment

saihaj commented Oct 25, 2022 •

edited

changeset-bot bot commented Oct 25, 2022 •

edited

github-actions bot commented Oct 25, 2022 •

edited

🚀 Snapshot Release (`alpha`)

github-actions bot commented Oct 25, 2022 •

edited

github-actions bot commented Oct 25, 2022 •

edited