Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor): argument value parsing errors should return 400 #4827

Merged
merged 4 commits into from Nov 7, 2022

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Nov 7, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

🦋 Changeset detected

Latest commit: b4c1437

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@graphql-tools/utils Minor
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/delegate Patch
@graphql-tools/executor Patch
@graphql-tools/graphql-tag-pluck Patch
@graphql-tools/import Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/url-loader Patch
graphql-tools Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 210       ✗ 0  
     data_received..................: 24 MB   2.4 MB/s
     data_sent......................: 90 kB   9.0 kB/s
     http_req_blocked...............: avg=5.85µs   min=2.7µs   med=3.8µs   max=212.9µs  p(90)=4.86µs   p(95)=5.08µs  
     http_req_connecting............: avg=1.43µs   min=0s      med=0s      max=150.7µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=88.87ms  min=75.46ms med=84.51ms max=185.78ms p(90)=95.3ms   p(95)=133.74ms
       { expected_response:true }...: avg=88.87ms  min=75.46ms med=84.51ms max=185.78ms p(90)=95.3ms   p(95)=133.74ms
     http_req_failed................: 0.00%   ✓ 0         ✗ 105
     http_req_receiving.............: avg=218.98µs min=160.2µs med=179.5µs max=2.85ms   p(90)=214.4µs  p(95)=277.76µs
     http_req_sending...............: avg=80.35µs  min=22µs    med=30.6µs  max=1.86ms   p(90)=38.38µs  p(95)=70.18µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=88.57ms  min=75.26ms med=84.25ms max=185ms    p(90)=94.8ms   p(95)=133.53ms
     http_reqs......................: 105     10.487362/s
     iteration_duration.............: avg=95.27ms  min=80.23ms med=89.86ms max=203.21ms p(90)=107.46ms p(95)=138.61ms
     iterations.....................: 105     10.487362/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.4.8-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 8.5.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.15-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/executor 0.0.7-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-tag-pluck 7.3.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
graphql-tools 8.3.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/import 6.7.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.19-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/load 7.8.5-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/apollo-engine-loader 7.3.18-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/code-file-loader 7.3.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/git-loader 7.2.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/github-loader 7.3.18-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-file-loader 7.5.10-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/json-file-loader 7.4.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/module-loader 7.2.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.32-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.16.12-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/merge 8.3.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/mock 8.7.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/node-require 6.4.13-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/relay-operation-optimizer 6.5.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/resolvers-composition 6.5.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/schema 9.0.9-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.21-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.18-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/utils 9.1.0-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.2.11-alpha-20221107162323-6c755a1c npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://c6b20bbb.graphql-tools.pages.dev

@ardatan ardatan merged commit c0639dd into master Nov 7, 2022
@ardatan ardatan deleted the argument-value-400 branch November 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants