Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add cancellation to AsyncIterable correctly and leak #4887

Merged
merged 6 commits into from Dec 7, 2022

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Dec 7, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

🦋 Changeset detected

Latest commit: e712846

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@graphql-tools/executor-http Patch
@graphql-tools/utils Patch
@graphql-tools/delegate Patch
@graphql-tools/url-loader Patch
@graphql-tools/batch-delegate Patch
@graphql-tools/batch-execute Patch
@graphql-tools/executor Patch
@graphql-tools/graphql-tag-pluck Patch
@graphql-tools/import Patch
@graphql-tools/links Patch
@graphql-tools/load Patch
@graphql-tools/merge Patch
@graphql-tools/mock Patch
@graphql-tools/node-require Patch
@graphql-tools/relay-operation-optimizer Patch
@graphql-tools/resolvers-composition Patch
@graphql-tools/schema Patch
@graphql-tools/stitch Patch
@graphql-tools/stitching-directives Patch
@graphql-tools/wrap Patch
@graphql-tools/apollo-engine-loader Patch
@graphql-tools/code-file-loader Patch
@graphql-tools/git-loader Patch
@graphql-tools/github-loader Patch
@graphql-tools/graphql-file-loader Patch
@graphql-tools/json-file-loader Patch
@graphql-tools/module-loader Patch
@graphql-tools/prisma-loader Patch
@graphql-tools/executor-apollo-link Patch
@graphql-tools/executor-graphql-ws Patch
@graphql-tools/executor-legacy-ws Patch
@graphql-tools/executor-urql-exchange Patch
graphql-tools Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 236      ✗ 0  
     data_received..................: 28 MB   2.7 MB/s
     data_sent......................: 101 kB  10 kB/s
     http_req_blocked...............: avg=5.21µs   min=2.8µs   med=3.5µs   max=178.3µs  p(90)=4.33µs   p(95)=4.85µs  
     http_req_connecting............: avg=1.03µs   min=0s      med=0s      max=121.6µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=79.8ms   min=69.9ms  med=75.54ms max=184.87ms p(90)=87.94ms  p(95)=113.07ms
       { expected_response:true }...: avg=79.8ms   min=69.9ms  med=75.54ms max=184.87ms p(90)=87.94ms  p(95)=113.07ms
     http_req_failed................: 0.00%   ✓ 0        ✗ 118
     http_req_receiving.............: avg=173.71µs min=116.3µs med=136.6µs max=537.4µs  p(90)=266.33µs p(95)=275.39µs
     http_req_sending...............: avg=153.88µs min=18.1µs  med=25.05µs max=3.5ms    p(90)=37.22µs  p(95)=880.76µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=79.48ms  min=69.74ms med=75.25ms max=184.54ms p(90)=87.24ms  p(95)=112.91ms
     http_reqs......................: 118     11.75299/s
     iteration_duration.............: avg=85.05ms  min=74.52ms med=80.51ms max=190.22ms p(90)=93.2ms   p(95)=117.64ms
     iterations.....................: 118     11.75299/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/batch-delegate 8.4.12-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/batch-execute 8.5.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/delegate 9.0.19-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor 0.0.11-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-apollo-link 0.0.5-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-graphql-ws 0.0.5-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-http 0.0.6-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-legacy-ws 0.0.5-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/executor-urql-exchange 0.0.5-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-tag-pluck 7.4.2-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
graphql-tools 8.3.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/import 6.7.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/links 8.3.23-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/load 7.8.8-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/apollo-engine-loader 7.3.21-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/code-file-loader 7.3.15-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/git-loader 7.2.15-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/github-loader 7.3.22-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/graphql-file-loader 7.5.13-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/json-file-loader 7.4.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/module-loader 7.2.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/prisma-loader 7.2.44-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/url-loader 7.16.24-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/merge 8.3.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/mock 8.7.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/node-require 6.4.16-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/relay-operation-optimizer 6.5.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/resolvers-composition 6.5.14-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/schema 9.0.12-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 8.7.31-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/stitching-directives 2.3.22-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/utils 9.1.3-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎
@graphql-tools/wrap 9.2.20-alpha-20221207150416-33ee0e52 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://416a8ad7.graphql-tools.pages.dev

@ardatan ardatan merged commit 904fe77 into master Dec 7, 2022
@ardatan ardatan deleted the fix-leak-abortctrl branch December 7, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant