Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildHTTPExecutor should return response as it was after exhausting all retry attempts #5372

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tian-sheng-low
Copy link

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

BuildHTTPExecutor should always return GraphQLError when subschema returns 5XX error.
Null retry option skip the 500 error check and the executor return plain JSON of the 5XX error.

Related # (issue)

#5371

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

Please refer to the related issue.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-tools/...:
  • NodeJS:

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

鈿狅笍 No Changeset found

Latest commit: 8d236fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tian-sheng-low tian-sheng-low marked this pull request as ready for review June 22, 2023 09:53
@tian-sheng-low tian-sheng-low marked this pull request as draft June 22, 2023 10:01
@tian-sheng-low tian-sheng-low force-pushed the fix_buildhttpexecutor_error_handle branch from ba138b9 to 11cfa9d Compare June 22, 2023 10:04
@tian-sheng-low tian-sheng-low changed the title Make buildHTTPExecutor always return GraphQLError when subschema returns 5XX error buildHTTPExecutor returns plain json when subschema returns 5XX error Jun 22, 2023
@tian-sheng-low tian-sheng-low marked this pull request as ready for review June 22, 2023 10:23
@tian-sheng-low tian-sheng-low changed the title buildHTTPExecutor returns plain json when subschema returns 5XX error buildHTTPExecutor should return response as it was after exhausting all retry attempts Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant