Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better object merging #5594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better object merging #5594

wants to merge 2 commits into from

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Sep 14, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: fa3051a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/federation 1.1.10-alpha-20230914211201-fa3051af npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.0.2-alpha-20230914211201-fa3051af npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 166     ✗ 0  
     data_received..................: 19 MB   1.9 MB/s
     data_sent......................: 71 kB   7.1 kB/s
     http_req_blocked...............: avg=52.03µs  min=3µs     med=4µs      max=3.99ms   p(90)=4.6µs    p(95)=4.88µs  
     http_req_connecting............: avg=44.91µs  min=0s      med=0s       max=3.72ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=113.56ms min=92.2ms  med=105.43ms max=249.49ms p(90)=142.82ms p(95)=164.39ms
       { expected_response:true }...: avg=113.56ms min=92.2ms  med=105.43ms max=249.49ms p(90)=142.82ms p(95)=164.39ms
     http_req_failed................: 0.00%   ✓ 0       ✗ 83 
     http_req_receiving.............: avg=228.17µs min=155.5µs med=184.8µs  max=755.02µs p(90)=331.98µs p(95)=356.54µs
     http_req_sending...............: avg=127.97µs min=20.4µs  med=30.2µs   max=2.41ms   p(90)=84.14µs  p(95)=1.01ms  
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=113.2ms  min=92ms    med=105.24ms max=249.04ms p(90)=142.44ms p(95)=164.05ms
     http_reqs......................: 83      8.25634/s
     iteration_duration.............: avg=121.06ms min=98.06ms med=112.01ms max=259.75ms p(90)=156.01ms p(95)=170.24ms
     iterations.....................: 83      8.25634/s
     vus............................: 1       min=1     max=1
     vus_max........................: 1       min=1     max=1

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

💻 Website Preview

The latest changes are available as preview in: https://92b7b856.graphql-tools.pages.dev

queueMicrotask(() => {
Object.entries(resolverResult).forEach(([responseKey, sourcePropValue]) => {
if (sourcePropValue != null) {
object[responseKey] = sourcePropValue;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment Medium

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant