Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let graphql-tag-pluck load from astro files #5781

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

XiNiHa
Copy link
Contributor

@XiNiHa XiNiHa commented Dec 16, 2023

馃毃 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Adds .astro file support on graphql-tag-pluck.

Related #5780

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit tests.

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 16, 2023

馃 Changeset detected

Latest commit: 939a506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/code-file-loader Minor
@graphql-tools/graphql-tag-pluck Minor
@graphql-tools/git-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@XiNiHa XiNiHa force-pushed the feat/load-astro branch 3 times, most recently from 3442760 to b38c7af Compare December 16, 2023 18:17
@XiNiHa
Copy link
Contributor Author

XiNiHa commented Dec 16, 2023

There is a bug in @astrojs/compiler that the synchronous version also returns a Promise 馃う
withastro/compiler#911

@XiNiHa
Copy link
Contributor Author

XiNiHa commented Jan 20, 2024

I've workedaround the issue by using astrojs-compiler-sync.

@ardatan ardatan merged commit 2c6c1d6 into ardatan:master Jan 22, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants