No unnecessary inline fragment spreads for union types in federation and link dependencies #5913

enisdenjo · 2024-02-19T11:50:03Z

Link dependencies

Many of the dependencies in the monorepo are not linked and therefore not updated on new releases. They should! (Note that I haven't checked all deps, only those affected by this PR.)

Inline fragment spread

# supergraph.graphql

[...]

type Query @join__type(graph: ACCOUNTS) {
  fooBar: FooBar
}

union FooBar
  @join__type(graph: ACCOUNTS)
  @join__unionMember(graph: ACCOUNTS, member: "Foo")
  @join__unionMember(graph: ACCOUNTS, member: "Bar")

type Foo @join__type(graph: ACCOUNTS, key: "id") {
  id: ID!
  name: String
}

type Bar @join__type(graph: ACCOUNTS, key: "id") {
  id: ID!
  name: String
}

# gateway-query.graphql

{
  fooBar {
    ... on Foo {
      name
    }
    ... on Bar {
      name
    }
  }
}

# ACCOUNTS-query.graphql

query {
  __typename
  fooBar {
-   ... on FooBar
      ... on Foo {
        name
      }
      ... on Bar {
        name
      }
-   }
    __typename
  }
}

changeset-bot · 2024-02-19T11:50:07Z

🦋 Changeset detected

Latest commit: b27ae86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages

Name	Type
@graphql-tools/apollo-engine-loader	Patch
@graphql-tools/batch-delegate	Patch
@graphql-tools/batch-execute	Patch
@graphql-tools/delegate	Patch
@graphql-tools/executor	Patch
@graphql-tools/executor-apollo-link	Patch
@graphql-tools/executor-envelop	Patch
@graphql-tools/executor-graphql-ws	Patch
@graphql-tools/executor-http	Patch
@graphql-tools/executor-legacy-ws	Patch
@graphql-tools/executor-urql-exchange	Patch
@graphql-tools/executor-yoga	Patch
@graphql-tools/federation	Patch
@graphql-tools/github-loader	Patch
@graphql-tools/graphql-file-loader	Patch
@graphql-tools/import	Patch
@graphql-tools/json-file-loader	Patch
@graphql-tools/links	Patch
@graphql-tools/load	Patch
@graphql-tools/merge	Patch
@graphql-tools/mock	Patch
@graphql-tools/module-loader	Patch
@graphql-tools/node-require	Patch
@graphql-tools/prisma-loader	Patch
@graphql-tools/relay-operation-optimizer	Patch
@graphql-tools/resolvers-composition	Patch
@graphql-tools/schema	Patch
@graphql-tools/stitch	Patch
@graphql-tools/stitching-directives	Patch
@graphql-tools/url-loader	Patch
federation-benchmark	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-02-19T11:51:52Z

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 312       ✗ 0  
     data_received..................: 36 MB   3.6 MB/s
     data_sent......................: 134 kB  13 kB/s
     http_req_blocked...............: avg=4.03µs   min=2.09µs   med=2.71µs   max=174.56µs p(90)=3.85µs  p(95)=4.26µs  
     http_req_connecting............: avg=739ns    min=0s       med=0s       max=115.4µs  p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=60.18ms  min=46.63ms  med=56.56ms  max=144.98ms p(90)=68.73ms p(95)=94.05ms 
       { expected_response:true }...: avg=60.18ms  min=46.63ms  med=56.56ms  max=144.98ms p(90)=68.73ms p(95)=94.05ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 156
     http_req_receiving.............: avg=138.19µs min=103.83µs med=133.65µs max=270.11µs p(90)=157µs   p(95)=172.16µs
     http_req_sending...............: avg=30.28µs  min=19.94µs  med=24.94µs  max=717.94µs p(90)=31.69µs p(95)=35.84µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=60.01ms  min=46.48ms  med=56.39ms  max=144.65ms p(90)=68.57ms p(95)=93.87ms 
     http_reqs......................: 156     15.539356/s
     iteration_duration.............: avg=64.32ms  min=51.28ms  med=60.77ms  max=160.04ms p(90)=75.45ms p(95)=98.08ms 
     iterations.....................: 156     15.539356/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

github-actions · 2024-02-19T11:51:52Z

🚀 Snapshot Release (`alpha`)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
`@graphql-tools/batch-delegate`	`9.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/batch-execute`	`9.0.4-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/delegate`	`10.0.4-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor`	`1.2.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-apollo-link`	`1.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-envelop`	`2.0.4-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-graphql-ws`	`1.1.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-http`	`1.0.9-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-legacy-ws`	`1.0.6-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-urql-exchange`	`1.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/executor-yoga`	`2.0.4-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/federation`	`1.1.17-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`graphql-tools`	`9.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/import`	`7.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/links`	`9.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/load`	`8.0.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/apollo-engine-loader`	`8.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/github-loader`	`8.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/graphql-file-loader`	`8.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/json-file-loader`	`8.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/module-loader`	`8.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/prisma-loader`	`8.0.3-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/url-loader`	`8.0.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/merge`	`9.0.3-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/mock`	`9.0.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/node-require`	`7.0.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/relay-operation-optimizer`	`7.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/resolvers-composition`	`7.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/schema`	`10.0.3-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitch`	`9.0.5-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/stitching-directives`	`3.0.1-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎
`@graphql-tools/wrap`	`10.0.2-alpha-20240222154539-b27ae8605c354eed2b24844a475c8889ccc90dfb`	npm ↗︎ unpkg ↗︎

github-actions · 2024-02-19T11:54:09Z

💻 Website Preview

The latest changes are available as preview in: https://d9ff513e.graphql-tools.pages.dev

EmrysMyrddin · 2024-02-23T11:05:28Z

packages/delegate/src/prepareGatewayDocument.ts

+        type = isNonNullType(type) ? type.ofType : type;
+        if (
+          type != null &&
+          isAbstractType(getNamedType(type)) &&


Why do we need to spread on abstract type ?
Shouldn't the spread be inside the selection set of this type, to spread inline fragment for each final types possible ?

Not 100%, I just know that we need to spread interfaces and the _Entity union. Omitting either (or both) fails a bunch of data-fetching tests. Maybe @ardatan can shine some light. :D

enisdenjo requested a review from ardatan February 19, 2024 11:50

ardatan approved these changes Feb 19, 2024

View reviewed changes

enisdenjo changed the title ~~No unnecessary inline fragment spreads for union types in federation~~ No unnecessary inline fragment spreads for union types in federation and link dependencies Feb 22, 2024

enisdenjo and others added 10 commits February 22, 2024 16:37

failing test

d424db8

nospread lol

0cc4833

changset

6f9059f

use latest delegate tool

0074983

chore(dependencies): updated changesets for modified dependencies

4ed66a2

because of different graphql print options, use toContain

fe738fb

fragment spread on required

85dcedc

handle nonnullable types

7a2b31b

chore(dependencies): updated changesets for modified dependencies

588a0a7

link deps

e8fd678

enisdenjo force-pushed the fragment-union branch from b61790c to e8fd678 Compare February 22, 2024 15:38

github-actions bot and others added 3 commits February 22, 2024 15:38

chore(dependencies): updated changesets for modified dependencies

a024366

revert misses

a3e669f

no only

b27ae86

EmrysMyrddin reviewed Feb 23, 2024

View reviewed changes

EmrysMyrddin approved these changes Feb 23, 2024

View reviewed changes

enisdenjo merged commit 83c0af0 into master Feb 23, 2024
30 checks passed

enisdenjo deleted the fragment-union branch February 23, 2024 12:29

theguild-bot mentioned this pull request Feb 23, 2024

Upcoming Release Changes #5929

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No unnecessary inline fragment spreads for union types in federation and link dependencies #5913

No unnecessary inline fragment spreads for union types in federation and link dependencies #5913

enisdenjo commented Feb 19, 2024 •

edited

changeset-bot bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

EmrysMyrddin Feb 23, 2024

enisdenjo Feb 23, 2024

No unnecessary inline fragment spreads for union types in federation and link dependencies #5913

No unnecessary inline fragment spreads for union types in federation and link dependencies #5913

Conversation

enisdenjo commented Feb 19, 2024 • edited

Link dependencies

Inline fragment spread

changeset-bot bot commented Feb 19, 2024 • edited

🦋 Changeset detected

github-actions bot commented Feb 19, 2024 • edited

✅ Benchmark Results

github-actions bot commented Feb 19, 2024 • edited

🚀 Snapshot Release (alpha)

github-actions bot commented Feb 19, 2024 • edited

💻 Website Preview

EmrysMyrddin Feb 23, 2024

Choose a reason for hiding this comment

enisdenjo Feb 23, 2024

Choose a reason for hiding this comment

enisdenjo commented Feb 19, 2024 •

edited

changeset-bot bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

github-actions bot commented Feb 19, 2024 •

edited

🚀 Snapshot Release (`alpha`)

github-actions bot commented Feb 19, 2024 •

edited