Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stitch): computed fields resolving via a root field returning an interface #6179

Merged
merged 10 commits into from
May 17, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 14, 2024

Support computed fields resolved via a root field returning an interface
When a computed field returning an object, and that field is resolved via an interface, the computed field will now be resolved correctly.

Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 0e154e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/stitch Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 14, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/stitch 9.2.9-alpha-20240516084910-0e154e65cb9e69b39c05eac324ed43aaf20ce886 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented May 14, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 332       ✗ 0  
     data_received..................: 39 MB   3.8 MB/s
     data_sent......................: 142 kB  14 kB/s
     http_req_blocked...............: avg=3.88µs   min=1.96µs   med=2.55µs   max=174.34µs p(90)=3.78µs   p(95)=3.99µs  
     http_req_connecting............: avg=725ns    min=0s       med=0s       max=120.44µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=56.32ms  min=47.68ms  med=52.3ms   max=149.27ms p(90)=62.13ms  p(95)=90.34ms 
       { expected_response:true }...: avg=56.32ms  min=47.68ms  med=52.3ms   max=149.27ms p(90)=62.13ms  p(95)=90.34ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 166
     http_req_receiving.............: avg=133.73µs min=100.75µs med=128.58µs max=485.61µs p(90)=146.94µs p(95)=152.97µs
     http_req_sending...............: avg=25.42µs  min=18.97µs  med=24.29µs  max=149.96µs p(90)=29.67µs  p(95)=35.08µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=56.16ms  min=47.51ms  med=52.15ms  max=148.73ms p(90)=61.95ms  p(95)=90.16ms 
     http_reqs......................: 166     16.546302/s
     iteration_duration.............: avg=60.41ms  min=51.24ms  med=56.31ms  max=152.99ms p(90)=66.02ms  p(95)=94.13ms 
     iterations.....................: 166     16.546302/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented May 14, 2024

💻 Website Preview

The latest changes are available as preview in: https://e6ee4cb0.graphql-tools.pages.dev

@ardatan ardatan marked this pull request as draft May 14, 2024 11:50
@ardatan ardatan marked this pull request as ready for review May 14, 2024 12:05
@ardatan ardatan marked this pull request as draft May 14, 2024 13:07
@ardatan ardatan marked this pull request as ready for review May 15, 2024 14:01
@ardatan ardatan merged commit 03a47b1 into master May 17, 2024
30 checks passed
@ardatan ardatan deleted the resolved-field-interface branch May 17, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants