Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation/delegate): support @provides and do not merge errors and resolved objects #6187

Merged
merged 11 commits into from
May 17, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented May 16, 2024

Fixes on @graphql-tools/delegate;

If a subschema returns an error for specific field that is already resolved by another subschema, the error should not be merged with the resolved object.

Improvements on @graphql-tools/federation;

Respect @provides to optimize the query plan

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: a48648c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/delegate Patch
@graphql-tools/federation Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 336      ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 144 kB  14 kB/s
     http_req_blocked...............: avg=3.81µs   min=1.98µs   med=2.51µs   max=178.57µs p(90)=3.64µs  p(95)=3.85µs  
     http_req_connecting............: avg=683ns    min=0s       med=0s       max=114.82µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=55.58ms  min=48.22ms  med=51.27ms  max=152.07ms p(90)=60.08ms p(95)=90.14ms 
       { expected_response:true }...: avg=55.58ms  min=48.22ms  med=51.27ms  max=152.07ms p(90)=60.08ms p(95)=90.14ms 
     http_req_failed................: 0.00%   ✓ 0        ✗ 168
     http_req_receiving.............: avg=136.84µs min=105.12µs med=129.55µs max=503.85µs p(90)=149.6µs p(95)=183.61µs
     http_req_sending...............: avg=24.84µs  min=17µs     med=24.33µs  max=75.08µs  p(90)=31.21µs p(95)=34.78µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=55.41ms  min=48.06ms  med=51.12ms  max=151.51ms p(90)=59.93ms p(95)=89.99ms 
     http_reqs......................: 168     16.72608/s
     iteration_duration.............: avg=59.76ms  min=51.72ms  med=55.29ms  max=162.25ms p(90)=67.63ms p(95)=93.86ms 
     iterations.....................: 168     16.72608/s
     vus............................: 1       min=1      max=1
     vus_max........................: 1       min=1      max=1

Base automatically changed from resolved-field-interface to master May 17, 2024 13:30
@ardatan ardatan merged commit dfccfbf into master May 17, 2024
26 checks passed
@ardatan ardatan deleted the provides-support branch May 17, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants