Maintain original errors where possible

[stringbeans]

This is to complete and address the PR previously opened here: #485

This is to address the issue logged here: #480

Currently, if schema stitching is used, any local errors will be swallowed and "recreated", thereby losing the original stack trace and making it very hard to debug. Along the same lines as what @alexFaunt proposed, we will now attach the original errors to the error object.

TODO:

• Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

[apollo-cla]

@stringbeans: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[alexFaunt]

cool, I think i was trying to crowbar a test into the schema stitching stuff, smart move having it separate 👍 going to close mine

[stringbeans]

@timrs2998 just curious, how does the timeline work for releasing new versions of graphql-tools? should we expect a new release with this fix in a weeks time? more? less?

thanks in advance :)

[timrs2998]

@stringbeans Sorry, I'm not affiliated with Apollo in any way, but am excited for these changes to be merged. You'll have to ask someone in the apollographql org.

[stringbeans]

not sure why the travis-ci build is failing... ive run npm test locally and it works fine. from the travis-ci logs it looks as though tsc is failing for some reason? is this a configuration issue on apollo's side?

[legopin]

Hi @stringbeans

"tsc" is the typeScript compiler.

I checked the travis CI and error messages seems to be related to this: apollographql/apollo-link#511

What do you think?

[stringbeans]

@legopin yes you are correct! it does look like its related to that issue above... im not sure if the failing build is the main stopper for this PR though as it doesnt look like any maintainers have been available to review the PR yet :(

if you or anyone else has any ideas on what i can do to fix the failing build im all ears! it doesnt seem related to the change in the PR but instead to external deps?

[legopin]

@stringbeans Looks like #658 addressed updating the external dependency of apollo-link, removing the import error. Maybe try merging with master again.

[stringbeans]

@legopin thanks for the reminder to merge master in again :) all is passing now!

[legopin]

@stringbeans Glad to hear it works now. Is there anyway to add @freiksenet as the reviewer?

[freiksenet]

Thanks!

[maxtechera]

Any update on when this change is going to be released?

[freiksenet]

Sorry for the delay. Published.