Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the new enum and union type extensions supported by graphql-js #951

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

jansuchy
Copy link
Contributor

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

Similarly to #948, this makes extractExtensionDefinitions understand the new union and enum type extensions

Please note that this PR does not make the enum and union schema extensions "just work" with
makeExecutableSchema and others, because these -- same as the input type extension added in #948 -- actually need graphql-js v14. But at least these definitions are not skipped and we get a good descriptive message what's wrong:

     Error: The UnionTypeExtension kind is not yet supported by extendSchema().

@jansuchy jansuchy force-pushed the more-graphql-schema-extensions branch 2 times, most recently from 713f854 to bdc302f Compare September 12, 2018 14:59
@jansuchy jansuchy force-pushed the more-graphql-schema-extensions branch from bdc302f to 6e05a7b Compare September 12, 2018 15:55
@mfix22 mfix22 requested a review from hwillson October 23, 2018 21:27
Copy link
Contributor

@mfix22 mfix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jansuchy this looks good to me. Could you update the CHANGELOG to add your commit to the current vNext instead?

@jansuchy
Copy link
Contributor Author

Thanks for review @mfix22 Changelog updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants