Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests failing #707

Merged
merged 1 commit into from Apr 11, 2022
Merged

fix tests failing #707

merged 1 commit into from Apr 11, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Apr 11, 2022 •
edited

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

fix tests

  • What is the current behavior?

The tests are failing

  • What is the new behavior?

The test are working:

The problem was originating from a newer version of python already including pathlib

  • Does this PR introduce a breaking change?

nop

  • Other information:

@umbynos umbynos added topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project labels Apr 11, 2022
@umbynos umbynos requested a review from per1234 April 11, 2022 08:51
@umbynos umbynos self-assigned this Apr 11, 2022
@umbynos umbynos mentioned this pull request Apr 11, 2022
Merged
@umbynos umbynos merged commit 7c9d2c6 into main Apr 11, 2022
@umbynos umbynos deleted the umbynos/fix_tests branch April 11, 2022 09:16
@umbynos umbynos mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@umbynos @per1234