Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if a signed URL is specified and use it download tools #953

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented May 16, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Code enhancement

  • What is the current behavior?

There are two ways of dowloading tools: Download and Install. The first one downloads and installs the tools from the package index only, while it is possible to provide a signed URL and a checksum to the second one to download a tool from there.

  • What is the new behavior?

Download is wrapped inside DownloadFromURL to align it to Install.

  • Does this PR introduce a breaking change?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 16, 2024
@MatteoPologruto MatteoPologruto self-assigned this May 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 20.10%. Comparing base (2fa738f) to head (afe92ea).
Report is 4 commits behind head on main.

Files Patch % Lines
v2/pkgs/tools.go 78.57% 6 Missing ⚠️
tools/download.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   20.64%   20.10%   -0.55%     
==========================================
  Files          42       42              
  Lines        2601     2537      -64     
==========================================
- Hits          537      510      -27     
+ Misses       1967     1943      -24     
+ Partials       97       84      -13     
Flag Coverage Δ
unit 20.10% <82.05%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

v2/pkgs/tools.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants