fix errors

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
argoproj · Apr 9, 2024 · 867fbcc · 867fbcc
1 parent fce53b9
commit 867fbcc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/reposerver/repository/repository_test.go b/reposerver/repository/repository_test.go
@@ -540,7 +540,10 @@ func TestHelmChartReferencingExternalValues_InvalidRefs(t *testing.T) {
 	// Empty refsource
 	service := newService(t, ".")
 
-	refSources, err := argo.GetRefSources(context.Background(), spec, repoDB)
+	refSources, err := argo.GetRefSources(context.Background(), argo.GetRefSourcesOptions{
+		Sources: spec.Sources,
+		Db:      repoDB,
+	})
 	require.NoError(t, err)
 
 	request := &apiclient.ManifestRequest{Repo: &argoappv1.Repository{}, ApplicationSource: &spec.Sources[0], NoCache: true, RefSources: refSources, HasMultipleSources: true, ProjectName: "something",
@@ -553,7 +556,10 @@ func TestHelmChartReferencingExternalValues_InvalidRefs(t *testing.T) {
 	service = newService(t, ".")
 
 	spec.Sources[1].Ref = "Invalid"
-	refSources, err = argo.GetRefSources(context.Background(), spec, repoDB)
+	refSources, err = argo.GetRefSources(context.Background(), argo.GetRefSourcesOptions{
+		Sources: spec.Sources,
+		Db:      repoDB,
+	})
 	require.NoError(t, err)
 
 	request = &apiclient.ManifestRequest{Repo: &argoappv1.Repository{}, ApplicationSource: &spec.Sources[0], NoCache: true, RefSources: refSources, HasMultipleSources: true, ProjectName: "something",
@@ -567,7 +573,10 @@ func TestHelmChartReferencingExternalValues_InvalidRefs(t *testing.T) {
 
 	spec.Sources[1].Ref = "ref"
 	spec.Sources[1].Chart = "helm-chart"
-	refSources, err = argo.GetRefSources(context.Background(), spec, repoDB)
+	refSources, err = argo.GetRefSources(context.Background(), argo.GetRefSourcesOptions{
+		Sources: spec.Sources,
+		Db:      repoDB,
+	})
 	require.NoError(t, err)
 
 	request = &apiclient.ManifestRequest{Repo: &argoappv1.Repository{}, ApplicationSource: &spec.Sources[0], NoCache: true, RefSources: refSources, HasMultipleSources: true, ProjectName: "something",

diff --git a/server/application/application.go b/server/application/application.go
@@ -1486,7 +1486,7 @@ func (s *Server) RevisionMetadata(ctx context.Context, q *application.RevisionMe
 
 	var source *v1alpha1.ApplicationSource
 	if a.Spec.HasMultipleSources() {
-                // If the historical data is empty (because the app hasn't been synced yet)
+		// If the historical data is empty (because the app hasn't been synced yet)
 		// we can use the source, if not (the app has been synced at least once)
 		// we have to use the history because sources can be added/removed
 		if len(a.Status.History) == 0 {