Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new Inputs/Sources tab to replace Parameters tab so that all sources from a multi-source app are displayed #17274

Closed
keithchong opened this issue Feb 22, 2024 · 0 comments · Fixed by #17275
Closed

Create new Inputs/Sources tab to replace Parameters tab so that all sources from a multi-source app are displayed #17274

keithchong opened this issue Feb 22, 2024 · 0 comments · Fixed by #17275
Assignees
@keithchong
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@keithchong
Copy link
Contributor

Summary

This is to cover the first part of the implementation details in the proposal: #17108.

Specifically, this will cover part #1 from here:
https://github.com/argoproj/argo-cd/blob/a0f800cdcc30ef36548cfdcccda0352080f77269/docs/proposals/multiple-sources-for-applications-ui.md#implementation-details

Currently, the UI only shows the first source of the multi-source app. With this change, all sources will be displayed in the new Inputs/Sources tab. The change should support the source field and the new sources field. The current behaviour will remain the same for single source apps using the source field.

Proposal

See #17108
@keithchong keithchong added the enhancement New feature or request label Feb 22, 2024
@keithchong keithchong self-assigned this Feb 22, 2024
@keithchong keithchong added the component:ui User interfaces bugs and enhancements label Feb 22, 2024
keithchong added a commit to keithchong/argo-cd that referenced this issue Feb 22, 2024
@keithchong
feat: Add Sources tab to show all sources of a multi-source app (argo…
b85bd62 
…proj#17274)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong mentioned this issue Feb 22, 2024
Merged
14 tasks
keithchong added a commit to keithchong/argo-cd that referenced this issue Feb 22, 2024
@keithchong
feat: Add Sources tab to show all sources of a multi-source app (argo…
f2db50e 
…proj#17274)

Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong added a commit to keithchong/argo-cd that referenced this issue Mar 1, 2024
@keithchong
feat: Add Sources tab to show all sources of a multi-source app (argo…
95246c5 
…proj#17274)

Signed-off-by: Keith Chong <kykchong@redhat.com>
ishitasequeira pushed a commit that referenced this issue Apr 16, 2024
@keithchong @agaudreault
feat: Add Sources tab to show all sources of a multi-source app (#17274…
f819870 
…) (#17275)

* feat: Add Sources tab to show all sources of a multi-source app (#17274)

Signed-off-by: Keith Chong <kykchong@redhat.com>

* Update ui/src/app/applications/components/resource-details/resource-details.tsx

Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>

* Remove getAppSources

Signed-off-by: Keith Chong <kykchong@redhat.com>

* Add address Ishita's comments. Add missing Ref field

Signed-off-by: Keith Chong <kykchong@redhat.com>

* Use single quotes

Signed-off-by: Keith Chong <kykchong@redhat.com>

---------

Signed-off-by: Keith Chong <kykchong@redhat.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Sources tab to show all sources of a multi-source app (#17274) keithchong/argo-cd
1 participant
@keithchong