New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Sources tab to show all sources of a multi-source app (#17274) #17275
Conversation
b85bd62
to
f2db50e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17275 +/- ##
==========================================
- Coverage 49.73% 49.55% -0.18%
==========================================
Files 274 273 -1
Lines 48948 48288 -660
==========================================
- Hits 24343 23928 -415
+ Misses 22230 21998 -232
+ Partials 2375 2362 -13 ☔ View full report in Codecov by Sentry. |
…proj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com>
f2db50e
to
95246c5
Compare
ui/src/app/applications/components/resource-details/resource-details.tsx
Outdated
Show resolved
Hide resolved
…etails.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. but a review from a "UI" folk/maintainer would be good to have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @keithchong. The PR looks great!! I just have a few comments.
ui/src/app/applications/components/resource-details/resource-details.tsx
Show resolved
Hide resolved
Signed-off-by: Keith Chong <kykchong@redhat.com>
…git into 17274-SourcesTab
Signed-off-by: Keith Chong <kykchong@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @keithchong! The PR LGTM 🚀
Fixes #17274
The original Multi-Source enhancement PR supported viewing only the first source of a multi-source application. The parameters were not editable either.
This PR adds a bit more support in that it will show all the sources of the multi-source application under a new Sources tab (which replaces the Parameters tab). Arguably, these changes could have been part of the original PR. The parameters are still read-only. (Making the input/parameters editable will be part of another PR.)
Note: There is effectively no change in behaviour for applications that still use the single
source
. The repo URL, path and related inputs are still shown in the Summary tab. When thesource
field is deprecated and removed, the corresponding code should be updated.This is just the first stage from the design proposal.
Checklist: