Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sources tab to show all sources of a multi-source app (#17274) #17275

Merged
merged 7 commits into from Apr 16, 2024

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented Feb 22, 2024

Fixes #17274

The original Multi-Source enhancement PR supported viewing only the first source of a multi-source application. The parameters were not editable either.

This PR adds a bit more support in that it will show all the sources of the multi-source application under a new Sources tab (which replaces the Parameters tab). Arguably, these changes could have been part of the original PR. The parameters are still read-only. (Making the input/parameters editable will be part of another PR.)

Note: There is effectively no change in behaviour for applications that still use the single source. The repo URL, path and related inputs are still shown in the Summary tab. When the source field is deprecated and removed, the corresponding code should be updated.

This is just the first stage from the design proposal.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

StickyTitleForSources

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.55%. Comparing base (f87897c) to head (f2db50e).
Report is 54 commits behind head on master.

❗ Current head f2db50e differs from pull request most recent head 42a8a83. Consider uploading reports for the commit 42a8a83 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17275      +/-   ##
==========================================
- Coverage   49.73%   49.55%   -0.18%     
==========================================
  Files         274      273       -1     
  Lines       48948    48288     -660     
==========================================
- Hits        24343    23928     -415     
+ Misses      22230    21998     -232     
+ Partials     2375     2362      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keithchong and others added 3 commits April 4, 2024 16:45
…etails.tsx

Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. but a review from a "UI" folk/maintainer would be good to have!

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keithchong. The PR looks great!! I just have a few comments.

Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keithchong! The PR LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants