Skip to content

fix: cherry-pick fixed cli admin dashboard cmd #16457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Nov 27, 2023

Cherry-pick #15800 and #16430 into 2.9 release

crenshaw-dev and others added 2 commits November 27, 2023 11:27
* chore(cli): clarify core mode code

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* rename function

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: fixed cli admin dashboard cmd

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

* feat: update docs

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>

---------

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@alexmt alexmt requested review from a team as code owners November 27, 2023 21:08
@alexmt alexmt requested a review from gdsoumya November 27, 2023 21:08
Signed-off-by: Rafal Pelczar <rafal@akuity.io>
@alexmt alexmt changed the title Cherry pick admin dashboard fix: cherry-pick fixed cli admin dashboard cmd Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (871b045) 49.98% compared to head (22f91ae) 50.00%.
Report is 13 commits behind head on release-2.9.

Files Patch % Lines
applicationset/utils/createOrUpdate.go 32.22% 50 Missing and 11 partials ⚠️
applicationset/utils/template_functions.go 67.74% 10 Missing ⚠️
cmd/argocd/commands/admin/dashboard.go 0.00% 5 Missing ⚠️
...cationset/controllers/applicationset_controller.go 33.33% 2 Missing and 2 partials ⚠️
cmd/argocd/commands/admin/admin.go 0.00% 1 Missing ⚠️
util/grpc/grpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.9   #16457      +/-   ##
===============================================
+ Coverage        49.98%   50.00%   +0.01%     
===============================================
  Files              266      267       +1     
  Lines            46074    46143      +69     
===============================================
+ Hits             23030    23073      +43     
- Misses           20784    20807      +23     
- Partials          2260     2263       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexmt alexmt merged commit e63273e into argoproj:release-2.9 Nov 27, 2023
@alexmt alexmt deleted the cherry-pick-admin-dashboard branch November 27, 2023 22:16
@thesuperzapper
Copy link

thesuperzapper commented Nov 29, 2023

@alexmt I am not 100% sure if #16267 ever made its way into the release-2.9 branch either, which was to fix a very similar issue.

Do we also need that?

@onematchfox
Copy link
Contributor

onematchfox commented Dec 10, 2023

Hey @crenshaw-dev / @leoluz / @alexmt ... Friendly reminder that you have library/module consumers out there. Please be careful about changing function names and signatures... This is technically a breaking change - just got caught out by this when bumping versions on terraform-provider-argocd and the only mention of this in the release notes is a [chore](fix: cherry-pick fixed cli admin dashboard cmd) 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants