Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Golang to 1.21.8 #17616

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Mar 25, 2024

Bump Golang in Dockerfiles to 1.21.8.

We cannot use 1.22 yet, see kubernetes-sigs/kubebuilder#3792 - Our codegen will fail NPEs.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis requested a review from a team as a code owner March 25, 2024 16:17
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.72%. Comparing base (05eea87) to head (94e7cd5).
Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17616      +/-   ##
==========================================
+ Coverage   49.44%   49.72%   +0.27%     
==========================================
  Files         273      274       +1     
  Lines       48662    48939     +277     
==========================================
+ Hits        24063    24334     +271     
+ Misses      22237    22230       -7     
- Partials     2362     2375      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit f87897c into argoproj:master Mar 25, 2024
28 checks passed
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants