Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't log certain fields #5662

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix: don't log certain fields #5662

merged 3 commits into from
Mar 3, 2021

Conversation

kshamajain99
Copy link
Contributor

@kshamajain99 kshamajain99 commented Mar 3, 2021 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@kshamajain99
fix: support longer cookie
6206bc9 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99
merge conflicts
69f6ee8 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99 kshamajain99 requested a review from alexmt March 3, 2021 00:52
kshamajain99
kshamajain99 commented Mar 3, 2021
View reviewed changes
util/exec/exec.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 3, 2021 •
edited

Codecov Report

Merging #5662 (6d0207c) into master (cdabf31) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5662      +/-   ##
==========================================
+ Coverage   40.96%   40.98%   +0.01%     
==========================================
  Files         144      144              
  Lines       19325    19327       +2     
==========================================
+ Hits         7917     7921       +4     
+ Misses      10303    10302       -1     
+ Partials     1105     1104       -1
Impacted Files Coverage Δ
util/exec/exec.go 100.00% <100.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdabf31...6d0207c. Read the comment docs.

@kshamajain99 kshamajain99 force-pushed the security branch 2 times, most recently from cc85894 to 348da56 Compare March 3, 2021 01:23
alexmt
alexmt requested changes Mar 3, 2021
View reviewed changes
util/exec/exec.go Outdated Show resolved Hide resolved
@kshamajain99
fix: don't log certain fields
6d0207c 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
@kshamajain99 kshamajain99 requested a review from alexmt March 3, 2021 02:07
alexmt
alexmt approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kshamajain99
Copy link
Contributor Author

argoproj/gitops-engine#232

@kshamajain99 kshamajain99 merged commit 7abfbe8 into argoproj:master Mar 3, 2021
kshamajain99 added a commit that referenced this pull request Mar 3, 2021
@kshamajain99
fix: don't log certain fields (#5662)
b51ba85 
* fix: support longer cookie

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* merge conflicts

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* fix: don't log certain fields

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
kshamajain99 added a commit to kshamajain99/argo-cd that referenced this pull request Mar 3, 2021
@kshamajain99
fix: redact sensitive data in logs (argoproj#5662)
528fb17 
Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
@kshamajain99 @Shubhama19
fix: don't log certain fields (argoproj#5662)
c0f898a 
* fix: support longer cookie

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* merge conflicts

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>

* fix: don't log certain fields

Signed-off-by: kshamajain99 <kshamajain99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kshamajain99 @codecov-io @alexmt