Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Pre-set statusbadge.url only when statusbadge is enabled #2658

Merged
merged 1 commit into from Apr 24, 2024
Merged

fix(argo-cd): Pre-set statusbadge.url only when statusbadge is enabled #2658

merged 1 commit into from Apr 24, 2024

Conversation

bojanraic
Copy link
Contributor

@bojanraic bojanraic commented Apr 22, 2024 •
edited

  • Pre-set statusbadge.url to global.domain URL only when statusbadge.enabled is true
  • Fix a minor comment typo

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@bojanraic
Copy link
Contributor Author

bojanraic commented Apr 22, 2024 •
edited

This is just a small tweak of #2656: pre-populate statusbadge.url with a URL based on global.domain only when statusbadge.enabled is true. This avoids adding an unnecessary config map entry if statusbadge is not used.

@mkilchhofer
Copy link
Member

This is just a small tweak of #2656: pre-populate statusbadge.url with a URL based on global.domain only when statusbadge.enabled is true. This avoids adding an unnecessary config map entry if statusbadge is not used.

Do you face issues when it is set but disabled? Or is it just cosmetics from your opinion?

Xref: #2657

@bojanraic
Copy link
Contributor Author

bojanraic commented Apr 23, 2024 •
edited

Do you face issues when it is set but disabled? Or is it just cosmetics from your opinion?

No issues, just cosmetics. In the previous iteration, one could consider it misleading or confusing if the badge url was pre populated, since badges are disabled by default.
With @yu-croco's suggestion, we can now explicitly set statusbadge.enabled to false and then do a check to determine if populating the default badge url value is warranted.

@github-actions github-actions bot added size/S and removed size/XS labels Apr 23, 2024
@bojanraic bojanraic force-pushed the fix/statusbadge-preset-url branch 3 times, most recently from 8102989 to 47e0c59 Compare April 23, 2024 17:08
@bojanraic
fix(argo-cd): Pre-set statusbadge.url only when statusbadge is enabled
a139834 
- Add `statusbadge.enabled` to values.yaml as `false`
- Pre-set `statusbadge.url` to `global.domain` URL only when `statusbadge.enabled` is `true`
- Update README.md
- Fix a minor comment typo

Signed-off-by: Bojan Raic <code@bojan.io>
@bojanraic bojanraic requested a review from yu-croco April 23, 2024 17:25
mkilchhofer
mkilchhofer approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

yu-croco
yu-croco approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM.

@yu-croco yu-croco merged commit da00680 into argoproj:main Apr 24, 2024
7 checks passed
@bojanraic bojanraic deleted the fix/statusbadge-preset-url branch April 24, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bojanraic @mkilchhofer @yu-croco