Skip to content

Commit

Permalink
chore: fix function name in comment (#12886)
Browse files Browse the repository at this point in the history
Signed-off-by: redismongo <yuanchaowei@outlook.com>
  • Loading branch information
redismongo committed Apr 4, 2024
1 parent 66d8351 commit 0b625a6
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions workflow/controller/operator_persist_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func TestPersistWithoutLargeWfSupport(t *testing.T) {
assert.Equal(t, wfv1.WorkflowError, woc.wf.Status.Phase)
}

// TestPersistWithoutLargeWfSupport verifies persistence error with no largeWFsuppport
// TestPersistErrorWithoutLargeWfSupport verifies persistence error with no largeWFsuppport
func TestPersistErrorWithoutLargeWfSupport(t *testing.T) {
defer makeMax()()
cancel, controller := newController()
Expand All @@ -87,7 +87,7 @@ func TestPersistErrorWithoutLargeWfSupport(t *testing.T) {
assert.Equal(t, wfv1.WorkflowError, wf.Status.Phase)
}

// TestPersistWithoutLargeWfSupport verifies persistence with largeWFsuppport
// TestPersistWithLargeWfSupport verifies persistence with largeWFsuppport
func TestPersistWithLargeWfSupport(t *testing.T) {
defer makeMax()()
cancel, controller := newController()
Expand Down Expand Up @@ -115,7 +115,7 @@ func TestPersistWithLargeWfSupport(t *testing.T) {
assert.Empty(t, woc.wf.Status.CompressedNodes)
}

// TestPersistWithoutLargeWfSupport verifies persistence error with largeWFsuppport
// TestPersistErrorWithLargeWfSupport verifies persistence error with largeWFsuppport
func TestPersistErrorWithLargeWfSupport(t *testing.T) {
defer makeMax()()
cancel, controller := newController()
Expand Down
2 changes: 1 addition & 1 deletion workflow/controller/operator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -977,7 +977,7 @@ func parseRetryMessage(message string) (int, error) {
return totalSeconds, nil
}

// TestProcessNodeRetries tests retrying when RetryOn.Error is disabled
// TestProcessNodesNoRetryWithError tests retrying when RetryOn.Error is disabled
func TestProcessNodesNoRetryWithError(t *testing.T) {
cancel, controller := newController()
defer cancel()
Expand Down
6 changes: 3 additions & 3 deletions workflow/controller/workflowpod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ script:
ls -al
`

// TestScriptTemplateWithVolume ensure we can a script pod with input artifacts
// TestScriptTemplateWithoutVolumeOptionalArtifact ensure we can a script pod with input artifacts
func TestScriptTemplateWithoutVolumeOptionalArtifact(t *testing.T) {
volumeMount := apiv1.VolumeMount{
Name: "input-artifacts",
Expand Down Expand Up @@ -499,7 +499,7 @@ func TestConditionalNoAddArchiveLocation(t *testing.T) {
assert.Nil(t, tmpl.ArchiveLocation)
}

// TestConditionalNoAddArchiveLocation verifies we do add archive location if it is needed for logs
// TestConditionalAddArchiveLocationArchiveLogs verifies we do add archive location if it is needed for logs
func TestConditionalAddArchiveLocationArchiveLogs(t *testing.T) {
ctx := context.Background()
woc := newWoc()
Expand All @@ -523,7 +523,7 @@ func TestConditionalAddArchiveLocationArchiveLogs(t *testing.T) {
assert.NotNil(t, tmpl.ArchiveLocation)
}

// TestConditionalNoAddArchiveLocation verifies we add archive location when it is needed
// TestConditionalArchiveLocation verifies we add archive location when it is needed
func TestConditionalArchiveLocation(t *testing.T) {
ctx := context.Background()
wf := wfv1.MustUnmarshalWorkflow(helloWorldWf)
Expand Down
2 changes: 1 addition & 1 deletion workflow/executor/common/common_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func (*MockKC) CreateArchive(ctx context.Context, containerName, sourcePath stri
return nil, nil
}

// TestScriptTemplateWithVolume ensure we can a script pod with input artifacts
// TestTerminatePodWithContainerName ensure we can a script pod with input artifacts
func TestTerminatePodWithContainerName(t *testing.T) {
// Already terminated.
mock := &MockKC{
Expand Down
2 changes: 1 addition & 1 deletion workflow/validate/validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1868,7 +1868,7 @@ spec:
args: ["echo {{inputs.parameters.parameter}}"]
`

// TestInvalidResourceWorkflow verifies an error against a workflow of an invalid resource.
// TestRuntimeResolutionOfVariableNames verifies an error against a workflow of an invalid resource.
func TestRuntimeResolutionOfVariableNames(t *testing.T) {
wf := unmarshalWf(runtimeResolutionOfVariableNames)
err := ValidateWorkflow(wftmplGetter, cwftmplGetter, wf, ValidateOpts{})
Expand Down

0 comments on commit 0b625a6

Please sign in to comment.