fix: correct pod names for inline templates. Fixes #12895 #12928
Conversation
Signed-off-by: AlbeeSo <suyashi1321@163.com>
agilgur5
changed the title
|
I see the UI logic for pod names has diverged a bit -- #7605 added a This logic could perhaps be simplified to just |
| if !strings.Contains(nodeName, ".inline") && templateName != "" { | ||
| prefix = fmt.Sprintf("%s-%s", workflowName, templateName) |
There was a problem hiding this comment.
| if !strings.Contains(nodeName, ".inline") && templateName != "" { | |
| prefix = fmt.Sprintf("%s-%s", workflowName, templateName) | |
| if templateName != "" { | |
| prefix = fmt.Sprintf("%s-%s", prefix, templateName) |
confirmed that this works and will match the UI as well -- see also #12964 .
an inline template will have no templateName, so it is equivalent to the previous logic.
also changed the prefix assignment a bit to simplify it
Screenshot using the Workflow from the issue:
agilgur5
added
the
problem/more information needed
Fixes #12895
Motivation
argo-workflows/workflow/util/pod_name.go
Line 60 in 87a2041
Incorrect pod names of inline templates will lead to empty UI logs problem.
Modifications
Verification
Test with the workflow mentioned in issue, got result like image post below:
