refactor: simplify getPodName and make consistent with back-end

[agilgur5]

Fixes #6982 (comment), Fixes #9168 (comment)

Motivation

Simplify getPodName as it required lots of args that could be retrieved from the existing Workflow and Node. Simplify surrounding code as well

Make it more consistent to the back-end as well, particularly after #12928.

• It seems to have diverged unintentionally within the same PR per fix: Add pod name format annotation. Fixes #6962 and #6989 #6982 (comment)

Modifications

• simplify calls to getPodName to only require the Workflow and Node as args

  • the rest can be derived from them, so we can remove all the duplicate, extraneous logic from all callers
    • workflow-details.tsx was particularly simplified as a result, a whole function was replaced with a one-liner
  • also make getPodName in the UI more closely match GeneratePodName on the back-end

• adjust pod-name.test.ts to match the modified args

  • also heavily simplify one of the test suites to cast some types instead of creating an unnecessary structure
• simplify other parts of pod-name.ts

  • simplify getTemplateNameFromNode to a one-liner that's easier to read and reads like the comment too

    • JS has truthiness, so if (node.templateName) checks for undefined, '', and others
    • node?. is not necessary per fix: Workflow details accessing undefined templateRef. Fixes #9167 #9168 (comment), and we can invert the conditional to if (node.templateRef?.template)
    • put it all together and you get a one-liner

  • slightly optimize ensurePodNamePrefixLength by moving the static calculation of maxPrefixLength into the module scope and outside the function scope

    • it does not change per function invocation
    • do the same on the back-end too in pod_name.go

  • use named functions for better tracing compared to const variables assigned to anonymous functions, same as refactor(ui): use named functions for better tracing #12062 et al

Verification

Existing tests pass

Also tested manually with the Workflow from #12895.

Screenshot:

Notes to Reviewers

It's easier to read each commit independently than it is to read the PR as a whole, that's why I split them that way

Future Work

1. pod-name.ts should only be exporting getPodName. the rest is not used anywhere except for the tests
   • The tests need a good bit of adjustment for this though, so for now, I left them as-is to show they still pass
2. The back-end's GeneratePodName can similarly be simplified, but it requires a lot more refactoring of functions of up the chain
   • partial workflow information, partial node information, etc gets passed down through a few layers of the call stack

[tczhao]

It's easier to read each commit independently than it is to read the PR as a whole, that's why I split them that way

This is gold