Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733 #10735

Merged
merged 12 commits into from
Mar 27, 2023

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Mar 22, 2023

Fixes #10733.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title fix: Release locks by terminating pending workflows immediately. Fixes #10733 fix: Immediately release locks by pending workflows that are shutting down. Fixes #10733 Mar 23, 2023
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan marked this pull request as ready for review March 24, 2023 18:34
@jessesuen
Copy link
Member

Based on our discussion, the agreed logic shall be:

  1. argo terminate of a Pending workflow waiting on a workflow-level lock, immediately transitions it to Succeeded without waiting for lock acquisition. No exit handlers run
  2. argo stop of a Pending workflow waiting on a workflow-level lock, will acquire the lock normally, and reconcile normally (exit handlers will run).

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member Author

terrytangyuan commented Mar 24, 2023

@jessesuen Updated the PR based on our discussion.

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan merged commit dd2f8cb into argoproj:master Mar 27, 2023
@terrytangyuan terrytangyuan deleted the fix-lock-terminating-wf branch March 27, 2023 15:46
terrytangyuan added a commit that referenced this pull request Mar 29, 2023
… down. Fixes #10733 (#10735)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
… down. Fixes argoproj#10733 (argoproj#10735)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminating Pending workflows waiting on a mutex/semaphore are not immediate
4 participants