Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use upstream go-git. Fixes #10091 #11149

Closed
wants to merge 3 commits into from

Conversation

weafscast
Copy link
Contributor

Fixes #10091

Motivation

go-git is back to maintenance and active for a couple of months already so we should contribute any changes back to upstream and switch back to upstream go-git: go-git/go-git

Modifications

Replace our own fork with upstream go-git

Verification

CI Tests

Signed-off-by: weafscast <weafscast@proton.me>
Signed-off-by: weafscast <weafscast@proton.me>
Signed-off-by: weafscast <weafscast@proton.me>
@weafscast
Copy link
Contributor Author

Will fix the issue upstream to pass the tests.

@terrytangyuan terrytangyuan marked this pull request as draft May 31, 2023 15:02
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Jun 18, 2023
@terrytangyuan
Copy link
Member

Any update on this?

@stale stale bot removed the problem/stale This has not had a response in some time label Jul 4, 2023
@weafscast
Copy link
Contributor Author

I wasn't able to dedicate a lot of time to this due to work commitments.

I will provide an update on this over the weekend. If I find that I cannot work on this, I will also communicate that in my update.

@weafscast
Copy link
Contributor Author

It seems like I can find some time this week to fix this.

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the problem/stale This has not had a response in some time label Sep 17, 2023
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc labels Nov 5, 2023
@terrytangyuan
Copy link
Member

terrytangyuan commented Jan 14, 2024

Closing in favor of #11149 #12515

@agilgur5
Copy link
Member

agilgur5 commented Jan 14, 2024

Superseded by #12515

EDIT:

Closing in favor of #11149

Oh I think that's what you meant to put there, #11149 is a self-link

@agilgur5 agilgur5 removed the problem/stale This has not had a response in some time label Jan 14, 2024
@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move away from go-git
3 participants