Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): don't show pagination warning on first page if all are displayed #11979

Merged
merged 1 commit into from
Oct 14, 2023
Merged

fix(ui): don't show pagination warning on first page if all are displayed #11979

merged 1 commit into from
Oct 14, 2023

Conversation

agilgur5
Copy link
Member

Fixes my review comment in #11973 (comment)
Fixes #11968 without a regression

Motivation

  • example: if you're on the first page and your pagination limit is 50 while you only have 10 total workflows, then the warning shouldn't show, as you already see all 10 workflows

Modifications

  • this new logic should handle both the first page and the last page issues
    • added a comment to word it out as well, which was actually very helpful in debugging and properly writing the logic (as it's a bit convoluted)

Verification

Tested manually. See #11973 (comment) for more details

Before:
Screenshot 2023-10-10 at 2 01 08 PM -- before

After:
Screenshot 2023-10-10 at 2 28 04 PM -- after

@agilgur5
fix(ui): don't show pagination warning on first page if all are displ…
fc847cc 
…ayed

- example: if you're on the first page and your pagination limit is 50 while you only have 10 total workflows, then the warning shouldn't show, as you already see all 10 workflows

- this new logic should handle both the first page and the last page issues
  - added a comment to word it out as well, which was actually very helpful in debugging and properly writing the logic (as it's a bit convoluted)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
This was referenced Oct 10, 2023
Merged
Closed
@terrytangyuan terrytangyuan enabled auto-merge (squash) October 10, 2023 21:35
@terrytangyuan
Copy link
Member

Will include in #11997

@terrytangyuan terrytangyuan merged commit 67c5fc9 into argoproj:master Oct 14, 2023
25 checks passed
@agilgur5 agilgur5 deleted the fix-ui-pagination-warning-page-one branch October 14, 2023 02:45
terrytangyuan pushed a commit that referenced this pull request Nov 3, 2023
@agilgur5 @terrytangyuan
fix(ui): don't show pagination warning on first page if all are displ…
0e04980 
…ayed (#11979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG UI: pagination warning is not always shown on last page of workflows
2 participants
@agilgur5 @terrytangyuan