fix(ui): remove "last month" default date filter mention from New Version Modal #11982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I removed and fixed the UI date filter in fa116b6 - if that fix is going to go into 3.4.x, we should remove the "New default" notice in the New Version Modal as it no longer exists - I added that notice in 24ab95c before I fixed & removed that default, but neither of those two commits have made it into a patch release yet - so they can be "squashed" together and the "New default" removed as such Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
changed the title
terrytangyuan
approved these changes
Oct 11, 2023
3 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Oct 19, 2023
…sion Modal (#11982) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…sion Modal (argoproj#11982) Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 3.4.12+: #11851 (comment)
Follow-up to #11742 and #11840
Motivation
Modifications
Verification
Ran
yarn lint. Otherwise this is just a simple text change to a modal