docs: change quick-start guide to use quick-start install. Fixes #12391 #12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quick start guide used the regular install.yaml for installation which does not configure the default user to be a valid service account to execute a workflow. This causes any example executions to fail. However the quick-start-minimal.yaml installation does configure this and is clearly suited for this doc so switch to that. fixes argoproj#12391 Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
terrytangyuan
approved these changes
Jan 3, 2024
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this pull request
Jan 4, 2024
…proj#12391 (argoproj#12445) Signed-off-by: Doug Goldstein <cardoe@cardoe.com> Signed-off-by: Raymond Chow <rchow@atlassian.com>
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this pull request
Jan 4, 2024
…proj#12391 (argoproj#12445) Signed-off-by: Doug Goldstein <cardoe@cardoe.com> Signed-off-by: Raymond Chow <rchow@atlassian.com>
3 tasks
4 tasks
|
Is there a reason why this documentation was not updated yet on the main page https://argo-workflows.readthedocs.io/en/stable/quick-start/ ? This update could save a lot of time to new users. |
4 tasks
|
@dgolja we didn't have versioned documentation until very recently (#11390), so backporting docs was not part of the process previously. For future reference, if you want something to be backported, the place to ask is in the release issue, in this case that's #11997. I'm currently managing backports and releases for 3.5.x, so I'll do that right now |
agilgur5
pushed a commit
that referenced
this pull request
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quick start guide used the regular install.yaml for installation which does not configure the default user to be a valid service account to execute a workflow. This causes any example executions to fail. However the quick-start-minimal.yaml installation does configure this and is clearly suited for this doc so switch to that.
Fixes #12391
Verification
Redid the quick start guide with the quick-start-minimal.yaml installation and it worked.