refactor(deps): remove moment dep and usage
#12611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`moment` has been [deprecated since Sep 2020](https://momentjs.com/docs/#/-project-status/) and recommends using native `Intl` or newer libraries that make use of native `Intl`, such as `luxon` and `dayjs` - `moment` is also a very large dependency and hence is ripe for pruning and replacement as well - replace all usage of `moment` with regular `Date` functions - `valueOf()` works the same way for `Date` and `moment` - `diff` doesn't exist, but it's a one-liner helper - `format` doesn't exist, but we can also use a simple helper for that - shave off X kb by replacing ~15 LoC Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
7 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the goals of #12059, just removing / replacing a large dep entirely.
Follow-up to #12097
Motivation
momenthas been deprecated since Sep 2020 and recommends using nativeIntlor newer libraries that make use of nativeIntl, such asluxonandday.jsmomentis also a very large dependency and hence is ripe for pruning and replacement as wellshave off X kb by replacing ~15 LoC
Modifications
momentwith regularDatefunctionsvalueOf()works the same way forDateandmomentdiffdoesn't exist, but it's a one-liner helperformatdoesn't exist, but we can also use a simple helper for thatVerification
TODO: insert screenshots of UI and
webpack-bundle-analyzerNOTE: This is still a draft right now as to fully remove
momentrequires upstream changes inargo-ui: argoproj/argo-ui#535