test: Add test for failed workflow artifact garbage collection. #12904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Garett MacGowan <garett.macgowan@gmail.com>
shuangkun
added
area/artifacts
tczhao
reviewed
Apr 8, 2024
| @@ -224,6 +224,59 @@ func (s *ArtifactsSuite) TestStoppedWorkflow() { | |||
| } | |||
| } | |||
|
|
|||
| func (s *ArtifactsSuite) TestFailedWorkflow() { | |||
There was a problem hiding this comment.
The failed workflow is part of fixtures.ToBeCompleted
maybe we can include this in the
argo-workflows/test/e2e/artifacts_test.go
Line 247 in 3496712
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #12845
Motivation
#12845 suggested a possible issue with artifactgc for failed workflows. This test verifies that artifactgc works for failed workflows.
Modifications
Add test for failed workflow artifact garbage collection.