Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add e2e test for #12636 #12959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

siwet
Copy link
Contributor

@siwet siwet commented Apr 21, 2024

Motivation

Add e2e test for "workflows that are retrying should not be deleted"

Previous content comes from:

Modifications

add TestWorkflowRetryTTLDeletePod in cli_test.go

Created with reference to #12905 (comment) suggestion

@siwet siwet force-pushed the test/e2e-test-for-12636 branch 2 times, most recently from aade1a0 to 1b95a86 Compare April 21, 2024 16:22
@agilgur5 agilgur5 self-assigned this Apr 21, 2024
@agilgur5 agilgur5 added area/controller Controller issues, panics area/build Build or GithubAction/CI issues labels Apr 21, 2024
@siwet siwet force-pushed the test/e2e-test-for-12636 branch from ee3e5f9 to 536693a Compare May 9, 2024 00:07
…eted"

Signed-off-by: Shiwei Tang <siwe.tang@gmail.com>
@siwet siwet force-pushed the test/e2e-test-for-12636 branch from 536693a to a47ec6b Compare May 9, 2024 01:19
@siwet siwet marked this pull request as ready for review May 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues area/controller Controller issues, panics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants