fix: Set default value to output parameters if suspend node timeout. Fixes #12230 #12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes argoproj#12230 Signed-off-by: oninowang <oninowang@tencent.com>
tczhao
reviewed
Apr 22, 2024
Signed-off-by: oninowang <oninowang@tencent.com>
tczhao
approved these changes
Apr 23, 2024
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12230
Motivation
Node is marked to
Succeededwhen suspension is expired, but the value of node outputs parameters was not filled up withValueFrom.DefaultifValueFrom.Supplied != nil.Modifications
Set default value to output parameters if suspend node timeout or mark the suspend node to error if raw output parameter has not been set and does not have a default value.
Verification
local test and add e2e test