refactor(controller): optimize PDB creation request #12974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of doing a `get` then a `create`, just do a `create` and ignore if it already exists Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
juliev0
approved these changes
Apr 27, 2024
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while discovering #12966.
#2286 seems to make an unnecessary request and that code still exists.
Motivation
Hit the k8s apiserver less, wait on network requests less
Modifications
getthen acreate, just do acreateand ignore if it already existsVerification
The test from #10944 should still pass