Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistently set executor log options #12979

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: consistently set executor log options #12979

wants to merge 8 commits into from

Commits on Apr 24, 2024

  1. fix: consistently set executor log options 

    - for all commands, including `emissary`, `agent`, `resource`, and `data`
  - set loglevel, gloglevel, and log format

- replace `getExecutorLogLevel` helper with `getExecutorLogOpts` helper
  - also add a helper in `/util/cmd` to get the gloglevel

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    de8c72b View commit details
    Browse the repository at this point in the history

  2. return string 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e004ec6 View commit details
    Browse the repository at this point in the history

  3. try conditional gloglevel? 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f71f76c View commit details
    Browse the repository at this point in the history

  4. empty string not nil 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f146b07 View commit details
    Browse the repository at this point in the history

  5. lookup can return nil? 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f318305 View commit details
    Browse the repository at this point in the history

  6. fix accidental resource action removal 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2b9973f View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. manual formatting since gofmt didn't do anything? 

    Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    f94d4b8 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'main' into fix-exec-log-opts

    @agilgur5
    agilgur5 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2781ddf View commit details
    Browse the repository at this point in the history