fix: ensure node phases propagate correctly. Fixes #12869

workflow/controller/dag.go

@@ -29,6 +29,9 @@ type dagContext struct {
 	// tasks are all the tasks in the template
 	tasks []wfv1.DAGTask
 
+	// convert to get the task
+	nodeToTask map[string]*wfv1.DAGTask
+
 	// visited keeps track of tasks we have already visited during an invocation of executeDAG
 	// in order to avoid duplicating work
 	visited map[string]bool
@@ -143,7 +146,7 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes wfv1.Nodes, isSh
 	// will take precedence as the branch phase for their descendents.
 	targetTaskPhases := make(map[string]wfv1.NodePhase)
 	for _, task := range targetTasks {
-		targetTaskPhases[d.taskNodeID(task)] = ""
+		targetTaskPhases[d.taskNodeID(task)] = wfv1.NodeOmitted
 	}
 
 	boundaryNode, err := nodes.Get(d.boundaryID)
@@ -168,13 +171,19 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes wfv1.Nodes, isSh
 			return wfv1.NodeRunning, nil
 		}
 
+		task := d.nodeToTask[curr.nodeId]
+
 		// Only overwrite the branchPhase if this node completed. (If it didn't we can just inherit our parent's branchPhase).
 		if node.Completed() {
-			branchPhase = node.Phase
+
+			if !curr.phase.FailedOrError() || (task != nil && !task.ContinuesOn(curr.phase)) {
+				branchPhase = node.Phase
+			}
 		}
 
+		previousPhase, isTargetTask := targetTaskPhases[node.ID]
 		// This node is a target task, so it will not have any children. Store or deduce its phase
-		if previousPhase, isTargetTask := targetTaskPhases[node.ID]; isTargetTask {
+		if isTargetTask {
 			// Since we want Failed or Errored phases to have preference over Succeeded in case of ambiguity, only update
 			// the deduced phase of the target task if it is not already Failed or Errored.
 			// Note that if the target task is NOT omitted (i.e. it Completed), then this check is moot, because every time
@@ -193,11 +202,15 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes wfv1.Nodes, isSh
 
 	// We only succeed if all the target tasks have been considered (i.e. its nodes created) and there are no failures
 	failFast := d.tmpl.DAG.FailFast == nil || *d.tmpl.DAG.FailFast
-	result := wfv1.NodeSucceeded
+	result := boundaryNode.Phase
+	if result == wfv1.NodeRunning {
+		result = wfv1.NodeSucceeded
+	}
+
 	for _, depName := range targetTasks {
 		branchPhase := targetTaskPhases[d.taskNodeID(depName)]
-		if branchPhase == "" {
-			result = wfv1.NodeRunning
+		if branchPhase == wfv1.NodeOmitted {
+			result = wfv1.NodeSucceeded
 			// If failFast is disabled, we will want to let all tasks complete before checking for failures
 			if !failFast {
 				break
@@ -211,7 +224,6 @@ func (d *dagContext) assessDAGPhase(targetTasks []string, nodes wfv1.Nodes, isSh
 			if task := d.GetTask(depName); task.ContinuesOn(branchPhase) {
 				continue
 			}
-
 			result = branchPhase
 			// If failFast is enabled, don't check to see if other target tasks are complete and fail now instead
 			if failFast {
@@ -246,6 +258,7 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 		boundaryID:     node.ID,
 		tasks:          tmpl.DAG.Tasks,
 		visited:        make(map[string]bool),
+		nodeToTask:     make(map[string]*wfv1.DAGTask),
 		tmpl:           tmpl,
 		wf:             woc.wf,
 		tmplCtx:        tmplCtx,
@@ -263,6 +276,12 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 		targetTasks = strings.Split(tmpl.DAG.Target, " ")
 	}
 
+	for _, task := range tmpl.DAG.Tasks {
+		task := task
+		taskId := dagCtx.taskNodeID(task.Name)
+		dagCtx.nodeToTask[taskId] = &task
+	}
+
 	// kick off execution of each target task asynchronously
 	onExitCompleted := true
 	for _, taskName := range targetTasks {
@@ -350,6 +369,8 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 	}
 	outputs, err := getTemplateOutputsFromScope(tmpl, scope)
 	if err != nil {
+		_ = woc.markNodePhase(nodeName, wfv1.NodeError)
+		err = woc.updateOutboundNodesForTargetTasks(dagCtx, targetTasks, nodeName)
 		woc.log.Errorf("unable to get outputs")
 		return node, err
 	}