build: simplify release notes as cross-platform #13054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- detect OS in the first command and use as env var - simplifies and consolidates the release notes for each version - slightly modify `make release-notes` target to handle this properly - only replace `$version` and not `$ARGO_OS` Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
changed the title
templarfelix
approved these changes
May 14, 2024
juliev0
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
detect OS in the first command and use as env var
slightly modify
make release-notestarget to handle this properly$versionand not$ARGO_OSVerification
make release-notesand checked that it only substituted$version