Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose validation webhook warnings in Argo CD UI #545

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mattes83
Copy link

This is a follow up of #493

I tried to implement the proposals of @crenshaw-dev

What do you think?

Sergey-Kizimov and others added 3 commits October 11, 2023 11:19
Signed-off-by: Sergey-Kizimov <sergey.kizimov@hiya.com>
Signed-off-by: Sergey-Kizimov <sergey.kizimov@hiya.com>
Signed-off-by: Matthias Teich <matthias.teich@gdata.de>
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a00ce82) 54.60% compared to head (40e9453) 54.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   54.60%   54.40%   -0.20%     
==========================================
  Files          41       41              
  Lines        4641     4661      +20     
==========================================
+ Hits         2534     2536       +2     
- Misses       1911     1927      +16     
- Partials      196      198       +2     
Files Coverage Δ
pkg/sync/common/types.go 50.00% <0.00%> (-4.17%) ⬇️
pkg/sync/sync_context.go 72.83% <20.00%> (-1.25%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cenk1cenk2
Copy link

This would be a great addition when using with operators that return some actual warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants