Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2023-46402 security fix #283

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

vr
Copy link
Contributor

@vr vr commented Mar 22, 2024

move to chainguard-dev git-urls to fix security issue because upstream is abandoned

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (d4eaae8) to head (c041a44).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files          35       35           
  Lines        3438     3438           
=======================================
  Hits         1903     1903           
  Misses       1256     1256           
  Partials      279      279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix lint and DCO issues ?

move to chainguard-dev git-urls to fix security issue because upstream is abandoned

Signed-off-by: Herve Commowick <herve.commowick@sundayapp.com>
Copy link
Contributor Author

@vr vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is fixed @pasha-codefresh

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vr vr requested a review from pasha-codefresh March 29, 2024 07:44
@pasha-codefresh
Copy link
Member

@vr waiting for confirmation from few other maintainers if they fine to change it , i think we will merge it today

@pasha-codefresh pasha-codefresh merged commit f485671 into argoproj:master Apr 3, 2024
5 checks passed
@vr vr deleted the CVE-2023-46402 branch April 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants