Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Portal warning on Next.js #802

Draft
wants to merge 2 commits into
base: reakit
Choose a base branch
from
Draft

Conversation

diegohaz
Copy link
Member

Closes #656

Work in progress

How to test?

TBD

Does this PR introduce breaking changes?

No

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b628579:

Sandbox Source
Reakit Configuration
youthful-thunder-2qvsn Issue #656

@ariakit-bot
Copy link

ariakit-bot commented Nov 29, 2020

Deploy preview for reakit ready!

Built with commit b628579

https://deploy-preview-802--reakit.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2020

Size Change: -15 B (0%)

Total Size: 256 kB

Filename Size Change
packages/reakit/dist/reakit.min.js 35.8 kB -15 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/reakit-playground/dist/reakit-playground.min.js 187 kB 0 B
packages/reakit-system-bootstrap/dist/reakit-system-bootstrap.min.js 19.1 kB 0 B
packages/reakit-system-palette/dist/reakit-system-palette.min.js 8.85 kB 0 B
packages/reakit-system/dist/reakit-system.min.js 2.45 kB 0 B
packages/reakit-utils/dist/reakit-utils.min.js 3.39 kB 0 B

compressed-size-action

@stale
Copy link

stale bot commented May 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 30, 2021
@diegohaz diegohaz removed the stale label May 31, 2021
@Grsmto
Copy link

Grsmto commented Aug 4, 2021

Is there anything we can do to help this one go through? 👀

@marcospassos
Copy link
Contributor

@diegohaz any progress on this or any workaround?
image

@diegohaz
Copy link
Member Author

diegohaz commented Jan 5, 2022

@marcospassos I paused the work on this PR to focus on v2, which has a more robust fix for this issue. In the meantime, you can install the version created for this PR ("reakit": "https://pkg.csb.dev/reakit/reakit/commit/b6285795/reakit") and check if it's working properly.

I don't remember the error on the CI, but that's probably the only thing blocking this PR.

@diegohaz diegohaz changed the base branch from main to v1 May 21, 2022 15:08
@stale
Copy link

stale bot commented Nov 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2022
@diegohaz diegohaz removed the stale label Nov 23, 2022
@espipj
Copy link

espipj commented Jan 6, 2023

Hello! is there any timeline for this to be merged in the near future? I've tried this:

@marcospassos I paused the work on this PR to focus on v2, which has a more robust fix for this issue. In the meantime, you can install the version created for this PR ("reakit": "https://pkg.csb.dev/reakit/reakit/commit/b6285795/reakit") and check if it's working properly.

I don't remember the error on the CI, but that's probably the only thing blocking this PR.

and it wouldn't work. I might be able to give some help 😃

Edit: it does work! repro in codesandbox here

What's left on this PR? would be great if it could be merged on v1 so that #656 can be closed?

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message outputted while using tooltip with nextjs
5 participants