Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public api #553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Public api #553

wants to merge 1 commit into from

Conversation

jwiesler
Copy link
Collaborator

@jwiesler jwiesler commented May 10, 2024

Observations:

  • I omitted auto derived impls and blanket impls, which brought down the api json file from 25mb to 7mb
  • cargo public-api diff does not work, I couldn't get features to be passed to diff (opened an issue for this)
  • The test workflow would work, however, the output is not diffed and the file is 7mb. So this file would have to be diffed manually and the pipeline would always just report "not the same". Maybe there is some nice diff tool that can be used to generate a diff in the pipeline.

Open questions:

  • Does public-api exposes some api to generate the diff programatically
  • Which features do we want to use to check this?
    • With diff we could check the whole matrix
    • With the test approach every combination of features will need a dedicated file which adds up quickly in repo size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant