Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better guides for quickstart #292

Merged
merged 3 commits into from May 9, 2024

Conversation

dejanzele
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.19%. Comparing base (4e1b2a6) to head (604bec3).
Report is 1 commits behind head on main.

❗ Current head 604bec3 differs from pull request most recent head 40fe75a. Consider uploading reports for the commit 40fe75a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   84.19%   84.19%   -0.01%     
==========================================
  Files          15       15              
  Lines        3461     3441      -20     
==========================================
- Hits         2914     2897      -17     
+ Misses        383      381       -2     
+ Partials      164      163       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove references to Kubecon from this so its more evergreen?

Copy link
Member

@richscott richscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw a typo, but it's not a deal-breaker. I agree that the KubeCon references should probably be removed.

Note that Lookout V1 images are no longer being built, so it's good that this PR doesn't update to latest versions of the images. I have a bunch of changes to remove all references to Lookout V1, and update to latest numbered versions of all images, but that can wait until after this PR is merged.

README.md Outdated Show resolved Hide resolved
richscott
richscott previously approved these changes May 9, 2024
Copy link
Member

@dave-gantenbein dave-gantenbein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dejanzele dejanzele merged commit 12042db into armadaproject:main May 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants