Fix job service gRPC stream cancellation handling #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sovietaced <sovietaced@gmail.com>
Sovietaced
changed the title
|
Unit test failures seem unrelated |
Sovietaced
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3555 where I tried to get cute about handling stream cancellation. I updated the code from performing string matching to checking whether the error was of type
context.Canceledand this introduced a cosmetic bug. The issue with this is that the errors returned in the stream are gRPC specific, so this pull request updates the unite test and fixes the logic tocontinueand not log the cancellation as some other error.